[HttpKernel] Read $_ENV when checking SHELL_VERBOSITY #25162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 26, 2017
ogizanagi
approved these changes
Nov 26, 2017
dunglas
approved these changes
Nov 26, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2017
…olas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Read $_ENV when checking SHELL_VERBOSITY | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Needed so that we can set the env var from `phpunit.xml.dist`. Commits ------- 7de1af4 [HttpKernel] Read $_ENV when checking SHELL_VERBOSITY
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2017
…xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] don't override existing verbosity env var | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While playing with the changes from #25162 I noticed that setting the `SHELL_VERBOSITY` env var in `phpunit.xml.dist` did not work as the kernel was setting the variable before the logic in the `Logger` class was executed. Commits ------- df4d6d6 don't override existing verbosity env var
|
For future reference, it's related to #24425. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed so that we can set the env var from
phpunit.xml.dist.