[HttpKernel] Keep legacy container files for concurrent requests #25190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c5841d to
c86504e
Compare
c86504e to
ee3b6fe
Compare
fabpot
approved these changes
Nov 29, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2017
…quests (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Keep legacy container files for concurrent requests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25177 | License | MIT | Doc PR | - Because concurrent requests might still be using them, old container files should not be removed immediately, but on a next dump of the container. Commits ------- ee3b6fe [HttpKernel] Keep legacy container files for concurrent requests
fabpot
added a commit
that referenced
this pull request
Nov 29, 2017
…ners (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Fix race condition when clearing old containers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Missed in #25190: when two concurrent requests create the new container concurrently, the last one would drop the old container files, because the first one just created the `*.legacyContainer` file. Commits ------- 9d553f5 [HttpKernel] Fix race condition when clearing old containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because concurrent requests might still be using them,
old container files should not be removed immediately,
but on a next dump of the container.