[DI] Improve service not found in service subscribers #25261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok for 3.4 also? not sure why wait half a year to start helping here. Besides it would ease tests a bit :) Really not sure about ignoring alternatives. When using a So leaning to WDYT? |
|
See #25367 for alternative. |
|
Even better alternative: #25381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here you go. Not sure about silently ignoring alternatives though.. but from
ServiceLocatorthis are all available services (not levenshtein tested or so) so this seems more useful.Perhaps do a levenshtein test here to reduce alternatives and then combine?