[Routing] Parse PHP constants in YAML routing files #25293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ostrolucky
commented
Dec 3, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
approved these changes
Dec 4, 2017
chalasr
approved these changes
Dec 4, 2017
xabbuh
approved these changes
Dec 4, 2017
|
@ostrolucky For next time, having just 1 PR instead of 3 would have been better. First, because all the changes are related, so having one commit with all changes make sense. Then, it's much faster for the core team to process one PR :) Thanks for the contribution. |
fabpot
approved these changes
Dec 4, 2017
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Dec 4, 2017
…strolucky) This PR was merged into the 4.1-dev branch. Discussion ---------- [Routing] Parse PHP constants in YAML routing files | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 6040e5f [Routing] Parse PHP constants in YAML routing files
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.