[Console] Add box style table #25301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maidmaid thanks for this contribution. And now the usual question for changes like this one: does this work perfectly on every operating system and terminal application? (We always have issues with Windows support). |
|
It supposed to work with DOS, according to the wiki page. Moreover, AppVeyor is green. But I didn't try on Windows. Maybe a Windows friend can give us a feedback? A friend like @ZHB maybe? ;) |
|
The test script (to use as-is, without my fork): <?php
require 'vendor/autoload.php';
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Helper\TableStyle;
use Symfony\Component\Console\Output\ConsoleOutput;
(new Table(new ConsoleOutput()))
->setStyle((new TableStyle())
->setHorizontalBorderChar('─')
->setVerticalBorderChar('│')
->setCrossingChar('┼')
)
->setHeaders(array('ISBN', 'Title', 'Author'))
->setRows(array(
array('99921-58-10-7', 'Divine Comedy', 'Dante Alighieri'),
array('9971-5-0210-0', 'A Tale of Two Cities', 'Charles Dickens'),
array('960-425-059-0', 'The Lord of the Rings', 'J. R. R. Tolkien'),
array('80-902734-1-6', 'And Then There Were None', 'Agatha Christie'),
))
->render()
; |
|
The result on Windows 10 command prompt :
|
fabpot
approved these changes
Dec 11, 2017
|
Thank you @maidmaid. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2017
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Add box style table | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / > Box-drawing characters, also known as line-drawing characters, are a form of semigraphics widely used in text user interfaces to draw various geometric frames and boxes. https://en.wikipedia.org/wiki/Box-drawing_character Box-drawing characters are done for the `TableStyle`; use them! Result:  Commits ------- 360a984 Add box style table
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Mar 17, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Make pretty the `box` style table | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / The console component is the 2nd most popular Symfony component with 70M of downloads. I think such composant has to provide faultless tables, with perfect management of borders, especially since the new `box` style table has been merged (cf symfony/symfony#25301).  Commits ------- 41f52b3a09 Make pretty the `box` style table
fabpot
added a commit
that referenced
this pull request
Mar 17, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Make pretty the `box` style table | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / The console component is the 2nd most popular Symfony component with 70M of downloads. I think such composant has to provide faultless tables, with perfect management of borders, especially since the new `box` style table has been merged (cf #25301).  Commits ------- 41f52b3 Make pretty the `box` style table
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box-drawing characters are done for the
TableStyle; use them!Result: