[HttpKernel] Decouple exception logging from rendering #25366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Dec 13, 2017
fabpot
approved these changes
Dec 14, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
… (ro0NL) This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpKernel] Decouple exception logging from rendering | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25266 | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Given your controller throws an exception and a custom exception listener sets a response. Before  After  ;-) edit: raising the priority for the profiler listener fixes the exception panel also. Commits ------- a203d31 [HttpKernel] Decouple exception logging from rendering
|
Nice @ro0NL 👍 |
xabbuh
reviewed
Dec 26, 2017
| 4.1.0 | ||
| ----- | ||
|
|
||
| * `ExceptionListener` now logs and collects exceptions at priority `2048` (previously logged at `-128` and collected at `0`) |
There was a problem hiding this comment.
Is it worth to add this to the upgrade file too?
There was a problem hiding this comment.
What exactly needs an upgrade step?
There was a problem hiding this comment.
I was thinking about other listeners that relied on this one being executed before/after themselves. Probably an edge case though that's not needed to be tackled.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given your controller throws an exception and a custom exception listener sets a response.
Before
After
;-)
edit: raising the priority for the profiler listener fixes the exception panel also.