[DI] Fix circular-aliases message #25382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Dec 7, 2017
| @@ -998,10 +998,14 @@ public function findDefinition($id) | |||
| $id = (string) $this->aliasDefinitions[$id]; | |||
|
|
|||
| if (isset($seen[$id])) { | |||
| throw new ServiceCircularReferenceException($id, array_keys($seen)); | |||
| $seen = array_values($seen); | |||
| $seen = array_slice($seen, array_search($id, $seen)); | |||
There was a problem hiding this comment.
the slicing part is not covered by the test (as the tests cover only the case where the loop starts at the beginning of the list).
Can you add another test covering this ?
516caa5 to
f1a7b07
Compare
xabbuh
approved these changes
Dec 8, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [DI] Fix circular-aliases message | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The missing bits in #25364 Commits ------- f1a7b07 [DI] Fix circular-aliases message
|
man, been debugging the container for 2 hours. Applying this change showed me the issues and could solve it in 5 min. So...when will there be a release? 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing bits in #25364