Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PropertyAccess] add more information to NoSuchPropertyException Message #25450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2017
Merged

[PropertyAccess] add more information to NoSuchPropertyException Message #25450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[PropertyAccess] add more information to NoSuchPropertyException Message
  • Loading branch information
Amrouche Hamza committed Dec 11, 2017
commit dee00f839381ea21924701cd846a36328716fae9
8 changes: 4 additions & 4 deletions src/Symfony/Component/PropertyAccess/PropertyAccessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ private static function throwInvalidArgumentException($message, $trace, $i)
$type = $trace[$i]['args'][0];
$type = is_object($type) ? get_class($type) : gettype($type);

throw new InvalidArgumentException(sprintf('Expected argument of type "%s", "%s" given', substr($message, $pos, strpos($message, ',', $pos) - $pos), $type));
throw new InvalidArgumentException(sprintf('Expected argument of type "%s", "%s" given.', substr($message, $pos, strpos($message, ',', $pos) - $pos), $type));
}
}

Expand Down Expand Up @@ -500,7 +500,7 @@ private function getReadAccessInfo($class, $property)
private function writeIndex($zval, $index, $value)
{
if (!$zval[self::VALUE] instanceof \ArrayAccess && !is_array($zval[self::VALUE])) {
throw new NoSuchIndexException(sprintf('Cannot modify index "%s" in object of type "%s" because it doesn\'t implement \ArrayAccess', $index, get_class($zval[self::VALUE])));
throw new NoSuchIndexException(sprintf('Cannot modify index "%s" in object of type "%s" because it doesn\'t implement \ArrayAccess.', $index, get_class($zval[self::VALUE])));
}

$zval[self::REF][$index] = $value;
Expand Down Expand Up @@ -541,7 +541,7 @@ private function writeProperty($zval, $property, $value)
} elseif (self::ACCESS_TYPE_MAGIC === $access[self::ACCESS_TYPE]) {
$object->{$access[self::ACCESS_NAME]}($value);
} elseif (self::ACCESS_TYPE_NOT_FOUND === $access[self::ACCESS_TYPE]) {
throw new NoSuchPropertyException(sprintf('Could not determine access type for property "%s" in class "%s".', $property, get_class($object)));
throw new NoSuchPropertyException(sprintf('Could not determine access type for property "%s" in class "%s"%s.', $property, get_class($object), isset($access[self::ACCESS_NAME]) ? ': '.$access[self::ACCESS_NAME] : ''));
} else {
throw new NoSuchPropertyException($access[self::ACCESS_NAME]);
}
Expand Down Expand Up @@ -589,7 +589,7 @@ private function writeCollection($zval, $property, $collection, $addMethod, $rem
/**
* Guesses how to write the property value.
*
* @param mixed $value
* @param mixed $value
*/
private function getWriteAccessInfo(string $class, string $property, $value): array
{
Expand Down