Clean up #25652
Closed
Clean up #25652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
requested changes
Jan 2, 2018
There was a problem hiding this comment.
I like this ... but the changes to the Markdown files stored in Tests/ dir should be reverted because otherwise tests will fail (these Markdown are the results or running some command, so we cannot modify them in any way or the command output won't match). Thanks.
|
@javiereguiluz Sorry for touch them, I've remove those changes 😅 |
nicolas-grekas
approved these changes
Jan 2, 2018
|
Thank you @carusogabriel. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 2, 2018
This PR was squashed before being merged into the 2.7 branch (closes #25652). Discussion ---------- Clean up | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've removed all white spaces and extra lines from our `markdown` files. Recently [I did it in our documentation](symfony/symfony-docs#8944), and thought would be interesting to replicate here 😄 Commits ------- acd0d7c Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed all white spaces and extra lines from our
markdownfiles. Recently I did it in our documentation, and thought would be interesting to replicate here 😄