Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Tweaked some styles in the profiler tables #25709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25670
License MIT
Doc PR -

To fix #25670 and other related minor issues, I propose some tweaks to the tables of the profiler panels.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(even-though I personally don't really like that we allow breaking lines in the middle of words by default in the first place)

@stof
Copy link
Member

stof commented Jan 9, 2018

Well, given that the route path and the route name will always be a single word (well, technically, spaces are allowed in route names IIRC, but they are quite uncommon), allowing to break words on them makes sense.

@fabpot
Copy link
Member

fabpot commented Jan 10, 2018

Thank you @javiereguiluz.

@fabpot fabpot merged commit bc80258 into symfony:2.8 Jan 10, 2018
fabpot added a commit that referenced this pull request Jan 10, 2018
This PR was merged into the 2.8 branch.

Discussion
----------

Tweaked some styles in the profiler tables

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25670
| License       | MIT
| Doc PR        | -

To fix #25670 and other related minor issues, I propose some tweaks to the tables of the profiler panels.

Commits
-------

bc80258 Tweaked some styles in the profiler tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants