[FrameworkBundle] fix tests #25759
Merged
[FrameworkBundle] fix tests #25759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a public alias so that we can retrieve the private aliased annotation_reader service in an after removing compiler pass.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] fix tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Add a public alias so that we can retrieve the private aliased annotation_reader service in an after removing compiler pass. Looks like I actually should have committed #25745 for the `3.4` branch to make `deps=high` tests pass there too. Commits ------- 6088dd3 [FrameworkBundle] fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a public alias so that we can retrieve the private aliased
annotation_reader service in an after removing compiler pass.
Looks like I actually should have committed #25745 for the
3.4branch to makedeps=hightests pass there too.