[Console] Add placeholder for line number in console exception fixtures #25794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis HHVM failure seems unrelated |
chalasr
approved these changes
Jan 15, 2018
There was a problem hiding this comment.
I would have just changed assertStringEqualsFile to assertStringMatchesFormatFile(), replacing the line number by %d in fixtures (https://phpunit.de/manual/current/en/appendixes.assertions.html#appendixes.assertions.assertStringMatchesFormatFile). Feel free to update if you want, fine for me as is. Thanks for taking care
|
I think |
|
Thank you @pierredup. |
chalasr
pushed a commit
that referenced
this pull request
Jan 15, 2018
…eption fixtures (pierredup) This PR was squashed before being merged into the 3.4 branch (closes #25794). Discussion ---------- [Console] Add placeholder for line number in console exception fixtures | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Add placeholders for exception line numbers for tests in `ApplicationTest` to make the tests more flexible Commits ------- 686d4f7 [Console] Add placeholder for line number in console exception fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add placeholders for exception line numbers for tests in
ApplicationTestto make the tests more flexible