Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Copied NO language files to the new NB locale #25812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Conversation

derrabus
Copy link
Member

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25792
License MIT
Doc PR N/A

This PR copies all NO language files to a new locale NB. It also adds unit tests to ensure that NB and NO will always contain the same translations. This way, we allow application developers to either use the generic NO language code or the more precise NB (e.g. if they need to distinguish between the NB and NN variants of the Norwegian language).

For further details, please have a look at the discussion in #25792.

@derrabus
Copy link
Member Author

AppVeyor build failure looks unrelated.

@derrabus
Copy link
Member Author

The HHVM job on Travis hangs, but the others are green. I doubt that I have introduced changes that break the HHVM build.

@fabpot
Copy link
Member

fabpot commented Jan 17, 2018

Thank you @derrabus.

@fabpot fabpot merged commit aee9b1e into symfony:2.7 Jan 17, 2018
fabpot added a commit that referenced this pull request Jan 17, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

Copied NO language files to the new NB locale

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25792
| License       | MIT
| Doc PR        | N/A

This PR copies all `NO` language files to a new locale `NB`. It also adds unit tests to ensure that `NB` and `NO` will always contain the same translations. This way, we allow application developers to either use the generic `NO` language code or the more precise `NB` (e.g. if they need to distinguish between the `NB` and `NN` variants of the Norwegian language).

For further details, please have a look at the discussion in #25792.

Commits
-------

aee9b1e Copied NO language files to the new NB locale.
@derrabus derrabus deleted the 2.7-no-nb branch January 17, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants