[SecurityBundle] Don't register in memory users as services #25837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Jan 18, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25820 |
| License | MIT |
| Doc PR | n/a |
b873324 to
d52b6c9
Compare
xabbuh
approved these changes
Jan 18, 2018
| @@ -160,7 +160,6 @@ | |||
|
|
|||
| <!-- Provisioning --> | |||
| <service id="security.user.provider.in_memory" class="%security.user.provider.in_memory.class%" abstract="true" public="false" /> | |||
| <service id="security.user.provider.in_memory.user" class="%security.user.provider.in_memory.user.class%" abstract="true" public="false" /> | |||
There was a problem hiding this comment.
reverted, proper deprecation in #25839
d52b6c9 to
13fa045
Compare
stof
approved these changes
Jan 18, 2018
fabpot
approved these changes
Jan 19, 2018
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jan 19, 2018
…s (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [SecurityBundle] Don't register in memory users as services | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25820 | License | MIT | Doc PR | n/a Commits ------- 13fa045 [SecurityBundle] Don't register in memory users as services
fabpot
added a commit
that referenced
this pull request
Jan 19, 2018
…vice (chalasr) This PR was merged into the 4.1-dev branch. Discussion ---------- [SecurityBundle] Deprecate in_memory.user abstract service | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #25837 (comment) | License | MIT | Doc PR | n/a Commits ------- 75a4117 [SecurityBundle] Deprecate in_memory.user abstract service
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.