do not conflict with egulias/email-validator 2.0+ #25861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaori
reviewed
Jan 20, 2018
| @@ -42,9 +42,6 @@ | |||
| "symfony/property-access": "For using the 2.4 Validator API", | |||
| "symfony/expression-language": "For using the 2.4 Expression validator" | |||
| }, | |||
| "conflict": { | |||
| "egulias/email-validator": ">=2.0" | |||
There was a problem hiding this comment.
Shouldn't this conflict still exist for the versions that are incompatible, or are all versions now compatible in this version of Symfony that's going to be released?
There was a problem hiding this comment.
This is the same as it is all currently maintained versions: The EmailValidator class checks if the installed version can be used when the strict option is enabled.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 21, 2018
This PR was merged into the 2.7 branch. Discussion ---------- do not conflict with egulias/email-validator 2.0+ | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25851 (comment) | License | MIT | Doc PR | Not allowing `egulias/email-validator` 2.0+ will prevent applications using this package from updating to the next patch release. Commits ------- 1a1aaa7 Revert "bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)"
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not allowing
egulias/email-validator2.0+ will prevent applications using this package from updating to the next patch release.