[Console] fixed typo in phpdoc#26019
Closed
nicolas-grekas wants to merge 1 commit into
Closed
Conversation
Member
nicolas-grekas
commented
Feb 2, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
Simperfit
approved these changes
Feb 2, 2018
Member
|
This change is wrong. |
chalasr
reviewed
Feb 2, 2018
|
|
||
| /** | ||
| * Initializes the command just after the input has been validated. | ||
| * Initializes the command before the input is validated. |
Member
There was a problem hiding this comment.
Actually most part of the input validation happens in Input::bind() before that initialize() is called, Input:: validate() is then called. I would reword it relying on method names
Member
Author
|
OK, I'm closing not need to spend more time here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.