[LocaleValidator] Use Symfony\Component\Intl\Locale instead of \Locale + read aliases from bundle only if it is required
#26069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phansys
commented
Feb 7, 2018
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
…es from bundle only if it is required
Symfony\Component\Intl\Locale instead of \Locale + read aliases from bundle only if it is requiredSymfony\Component\Intl\Locale instead of \Locale + read aliases from bundle only if it is required
fabpot
approved these changes
Feb 7, 2018
|
Good catch, thanks @phansys. |
fabpot
added a commit
that referenced
this pull request
Feb 7, 2018
…stead of `\Locale` + read aliases from bundle only if it is required (phansys) This PR was merged into the 4.1-dev branch. Discussion ---------- [LocaleValidator] Use `Symfony\Component\Intl\Locale` instead of `\Locale` + read aliases from bundle only if it is required |Q |A | |--- |--- | |Branch |master| |Bug fix? |no | |New feature? |no | |BC breaks? |no | |Deprecations?|no | |Tests pass? |yes | |Fixed tickets|n/a | |License |MIT | |Doc PR |n/a | Commits ------- 63497e1 Use `Symfony\Component\Intl\Locale` instead of `\Locale` + read aliases from bundle only if it is required
| @@ -42,12 +43,12 @@ public function validate($value, Constraint $constraint) | |||
|
|
|||
| $value = (string) $value; | |||
| if ($constraint->canonicalize) { | |||
| $value = \Locale::canonicalize($value); | |||
| $value = IntlLocale::canonicalize($value); | |||
nicolas-grekas
added a commit
that referenced
this pull request
Feb 12, 2018
…s-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [Intl] Add polyfill for Locale::canonicalize() | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Required after #26069 Commits ------- 972a330 [Intl] Add polyfill for Locale::canonicalize()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.