-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Workflow] Remove constraints on transition/place name + Updated Dumper #26079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lyrixx I have just checked and I think your .puml result is not syntactically valid. state "a" <<initial>>
state "b"
"a" --> "b": "t1" => That is not valid, you have a state "a" as a<<initial>>
state "b" as b
a --> b: "t1" Let me push the valid test fixtures for you to update the dumper accordingly :) |
Finally, there is a simpler way, just add cc @lyrixx thx! |
Thanks @Plopix for the review. I have testes in real life with really strange char and my code works.
And as it's already a workflow, the Here is the dump
|
Not really related question: Do you really use the |
Yes indeed the Ok to remove nofooter I agree with the less code less bug. (having the footer was prob too fancy)
I don't see the changes but I could have a look when done! |
15e35fc
to
55a5a7a
Compare
Indeed, I forgot to push ;) It's not pushed |
… + Updated Dumper (lyrixx) This PR was merged into the 4.1-dev branch. Discussion ---------- [Workflow] Remove constraints on transition/place name + Updated Dumper | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | (ping @Plopix : I changed a bit the puml dumper) Commits ------- 55a5a7a [Workflow] Remove constraints on transition/place name + Updated Dumper
(ping @Plopix : I changed a bit the puml dumper)