[HttpFoundation] Added a migrating session handler #26096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5139b08 to
4698577
Compare
|
This sounds interesting. But this will only migrate sessions that are accessed. How do you deal with session data from currently inactive users? I guess you still need to manually transfer the data from the old storage to the new one for those. Or you just let them expire after the migration phase. |
|
Hi @Tobion, we leave the migrating handler running for at least the session garbage collection period, as any sessions which have not been written to during that time are considered stale and may be removed by the session handlers themselves. |
joshlopes
approved these changes
Feb 13, 2018
|
@rossmotley is this PR ready on your side? |
|
@nicolas-grekas If there isn't anything to change with the code, then I think it's just adding something to the changelog and documentation. Should the changelog changes be added to this PR? |
|
The changelog of the component yes (not the root changelog as it is autogenerated) |
68bbd0e to
8ec1f99
Compare
8ec1f99 to
20af2bd
Compare
20uf
approved these changes
Mar 28, 2018
Tobion
suggested changes
Mar 31, 2018
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MigratingSessionHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MigratingSessionHandler.php
Outdated
Show resolved
Hide resolved
...mfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MigratingSessionHandlerTest.php
Outdated
Show resolved
Hide resolved
...mfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MigratingSessionHandlerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MigratingSessionHandler.php
Outdated
Show resolved
Hide resolved
...mfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MigratingSessionHandlerTest.php
Outdated
Show resolved
Hide resolved
70cea86 to
fb124b1
Compare
|
@Tobion I have made the requested changes |
fabpot
approved these changes
Apr 6, 2018
fb124b1 to
3acd548
Compare
|
Thank you @rossmotley. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2018
…ssmotley) This PR was squashed before being merged into the 4.1-dev branch (closes #26096). Discussion ---------- [HttpFoundation] Added a migrating session handler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#9496 - [x] gather feedback for my changes - [x] submit changes to the documentation - [x] update the changelog When migrating to a new session handler on a live system, it's useful to be able to do it with no loss of session data. This migrating handler allows the sessions to be written to an additional handler to enable a migration workflow like: * Switch to migrating handler, with your new handler as the 'write only' one. The old handler behaves as usual and sessions get written to the new one. * After verifying the data in the new handler (and after the session gc period), switch the migrating handler to use your old handler as the 'write only' one instead, so the sessions will now be read from the new handler. This step allows easier rollbacks. * After verifying everything, switch from the migrating handler to the new handler Commits ------- 3acd548 [HttpFoundation] Added a migrating session handler
|
We forgot implementing |
Tobion
added a commit
that referenced
this pull request
Apr 7, 2018
…SessionUpdateTimestampHandlerInterface (nicolas-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpFoundation] Have MigratingSessionHandler implement SessionUpdateTimestampHandlerInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Forgotten in #26096 Commits ------- 5d7117b [HttpFoundation] Have MigratingSessionHandler implement SessionUpdateTimestampHandlerInterface
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 24, 2018
…uiluz) This PR was merged into the 4.1 branch. Discussion ---------- Adding MigratingSessionHandler docs Adding `MigratingSessionHandler` documentation for symfony/symfony#26096 Commits ------- e93756f Added the versionadded directive 386f639 Reworded and simplified 7c8264d Update session_configuration.rst e971074 Update session_configuration.rst 91aa58d Adding MigratingSessionHandler docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating to a new session handler on a live system, it's useful to be able to do it with no loss of session data. This migrating handler allows the sessions to be written to an additional handler to enable a migration workflow like: