Tgalog translations for security and validation messages. #26106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Feb 9, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | no |
| Fixed tickets | none |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
added 4 commits
February 9, 2018 16:52
Translated the document in Tagalog Language.
Update secuity_tagalog translations.ar.xlf
Added tagalog translations
…tors_tagalog-translations.af.xlf Update validators_tagalog translations.af.xlf
|
@ergiegonzaga thanks for contributing this translation! However, there are some issues that we need to fix: instead of creating a new translation for Tagalog, you modified the translation for Arabic. This is how we can fix it:
Thank you! |
|
On a side note, you should generally not use your |
|
okay sir, how do i revert the changes I made in the
src/Symfony/Component/Security/Core/Resources/translations/security.ar.xlf
and src/Symfony/Component/Validator/Resources/translations/validators.af.xlf
files.
…On 9 February 2018 at 19:23, Christophe Coevoet ***@***.***> wrote:
On a side note, you should generally not use your master branch to open
pull requests. This will cause your master branch to be out of sync with
the upstream one, making it harder for you on your next contribution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26106 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AiZ406iUiEoO82taY3a6YYAQNbosfFjxks5tTCqegaJpZM4R_sdo>
.
|
|
@ergiegonzaga the simpler solution is to start a new PR using a feature branch created from the Symfony master (so starting clean). |
|
The easiest way to revert is to:
|
added 2 commits
February 9, 2018 20:07
Translations for Tagalog Dialect
security.tl.xlf
|
Okay sir i am already doing it now.
…On 9 February 2018 at 19:58, Javier Eguiluz ***@***.***> wrote:
The easiest way to revert is to:
1. Copy these contents -> https://raw.githubusercontent.
com/symfony/symfony/master/src/Symfony/Component/
Security/Core/Resources/translations/security.ar.xlf
<https://raw.githubusercontent.com/symfony/symfony/master/src/Symfony/Component/Security/Core/Resources/translations/security.ar.xlf>
and paste them into src/Symfony/Component/Security/Core/Resources/
translations/security.ar.xlf
2. Copy these contents -> https://raw.githubusercontent.
com/symfony/symfony/master/src/Symfony/Component/Validator/Resources/
translations/validators.af.xlf
<https://raw.githubusercontent.com/symfony/symfony/master/src/Symfony/Component/Validator/Resources/translations/validators.af.xlf>
into src/Symfony/Component/Validator/Resources/
translations/validators.af.xlf
3. Commit those changes and push them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26106 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AiZ40zAgwxUBN6Xd8qsbmWORbSuQyBbhks5tTDL6gaJpZM4R_sdo>
.
|
added 5 commits
February 9, 2018 20:14
Revert changes I've made earlier
security.ar.xlf
Tagalog translation
validators.tl.xlf
Revert Changes I've made earlier.
|
hi sir, I already submitted a new pull request, please take a look at it.
…On 9 February 2018 at 20:13, Ergie Gonzaga ***@***.***> wrote:
Okay sir i am already doing it now.
On 9 February 2018 at 19:58, Javier Eguiluz ***@***.***>
wrote:
> The easiest way to revert is to:
>
> 1. Copy these contents -> https://raw.githubusercontent.
> com/symfony/symfony/master/src/Symfony/Component/Security/
> Core/Resources/translations/security.ar.xlf
> <https://raw.githubusercontent.com/symfony/symfony/master/src/Symfony/Component/Security/Core/Resources/translations/security.ar.xlf>
> and paste them into src/Symfony/Component/Security
> /Core/Resources/translations/security.ar.xlf
> 2. Copy these contents -> https://raw.githubusercontent.
> com/symfony/symfony/master/src/Symfony/Component/Validator/
> Resources/translations/validators.af.xlf
> <https://raw.githubusercontent.com/symfony/symfony/master/src/Symfony/Component/Validator/Resources/translations/validators.af.xlf>
> into src/Symfony/Component/Validator/Resources/translations/
> validators.af.xlf
> 3. Commit those changes and push them.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#26106 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AiZ40zAgwxUBN6Xd8qsbmWORbSuQyBbhks5tTDL6gaJpZM4R_sdo>
> .
>
|
|
closing in favour of #26114 |
|
I also included in that pull request the reverted files that I have made
earlier sir..
…On 9 February 2018 at 21:17, Ergie Gonzaga ***@***.***> wrote:
hi sir, I already submitted a new pull request, please take a look at it.
On 9 February 2018 at 20:13, Ergie Gonzaga ***@***.***> wrote:
> Okay sir i am already doing it now.
>
> On 9 February 2018 at 19:58, Javier Eguiluz ***@***.***>
> wrote:
>
>> The easiest way to revert is to:
>>
>> 1. Copy these contents -> https://raw.githubusercontent.
>> com/symfony/symfony/master/src/Symfony/Component/Security/Co
>> re/Resources/translations/security.ar.xlf
>> <https://raw.githubusercontent.com/symfony/symfony/master/src/Symfony/Component/Security/Core/Resources/translations/security.ar.xlf>
>> and paste them into src/Symfony/Component/Security
>> /Core/Resources/translations/security.ar.xlf
>> 2. Copy these contents -> https://raw.githubusercontent.
>> com/symfony/symfony/master/src/Symfony/Component/Validator/R
>> esources/translations/validators.af.xlf
>> <https://raw.githubusercontent.com/symfony/symfony/master/src/Symfony/Component/Validator/Resources/translations/validators.af.xlf>
>> into src/Symfony/Component/Validator/Resources/translations/valid
>> ators.af.xlf
>> 3. Commit those changes and push them.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#26106 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AiZ40zAgwxUBN6Xd8qsbmWORbSuQyBbhks5tTDL6gaJpZM4R_sdo>
>> .
>>
>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.