[FrameworkBundle] feature: add the ability to search a route #26121

Simperfit · 2018-02-09T15:05:04Z

Q	A
Branch?	4.1
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#26033
License	MIT
Doc PR	symfony/symfony-docs#9236

This add the ability to search a route in the debug:router command.

Simperfit · 2018-02-09T15:48:49Z

Travis failure is unrelated

dunglas · 2018-02-09T22:15:08Z

Can you add a test please?

Simperfit · 2018-02-12T08:24:06Z

@dunglas I will do, I'm searching a way to add one, I have to look on other command's tests to test the choices.

Simperfit · 2018-02-14T12:04:26Z

Status: needs review

@dunglas test added

Simperfit · 2018-02-15T08:12:53Z

New test added that test the whole behaviour of the search.

dunglas · 2018-02-15T08:39:15Z

src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php

        }
    }
+
+    private function findRouteNameContaining(string $name, RouteCollection $routes)


You can use the : array return type.

dunglas · 2018-02-15T08:40:31Z

src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php

        if ($name) {
+            $matchingRoutes = $this->findRouteNameContaining($name, $routes);
+
+            if (!empty($matchingRoutes) && !$route = $routes->get($name)) {


Can be simplified in=

$matchingRoutes = $this->findRouteNameContaining($name, $routes) if ($matchingRoutes && !$route = $routes->get($name) {

dunglas · 2018-02-15T08:42:27Z

src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php

+    {
+        $foundRoutesNames = array();
+        foreach ($routes as $routeName => $route) {
+            if (false === stripos($routeName, $name)) {


Maybe can you invert the test, and put $foundRoutesNames[] = $routeName; in the if block to save 1 line (nitpicking).

stof · 2018-02-15T09:06:28Z

src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php

        $routes = $this->router->getRouteCollection();

        if ($name) {
+            $matchingRoutes = $this->findRouteNameContaining($name, $routes);


I would first try to get the route by exact name before searching route names. It is useless to search the matching routes if we already have a valid name.

chalasr · 2018-03-06T18:21:10Z

I suggest to drop the existing RouterDebugCommand test, it is semi-functional (use a mocked kernel) and all of its tests are covered by the one added here.

althaus · 2018-03-08T08:38:11Z

@chalasr Oh... didn't know about the change in the release cycles and the limit of 5 minors.

So I'll just overload the command with my own version of this change.

Simperfit · 2018-03-14T08:48:05Z

@chalasr @dunglas PR rebased, test fixed, semi-functional test deleted.

Simperfit · 2018-03-16T11:04:15Z

Travis failure is unrelated.

chalasr · 2018-03-20T13:52:38Z

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

 * The `container.service_locator` tag of `ServiceLocator`s is now autoconfigured.
-
+ * Add the ability to search a route in `debug:router`.
+


extra spaces I believe

fabpot · 2018-03-20T15:55:19Z

src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php

-            if (!$route = $routes->get($name)) {
+            if (!($route = $routes->get($name)) && $matchingRoutes = $this->findRouteNameContaining($name, $routes)) {
+                $default = 1 === count($matchingRoutes) ? $matchingRoutes[0] : null;
+                $name = $io->choice('Select one of the following routes to display its information', $matchingRoutes, $default);


Select one of the matching routes?

Simperfit · 2018-03-21T08:33:21Z

@fabpot done.

fabpot · 2018-03-21T08:35:13Z

src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php

-            if (!$route = $routes->get($name)) {
+            if (!($route = $routes->get($name)) && $matchingRoutes = $this->findRouteNameContaining($name, $routes)) {
+                $default = 1 === count($matchingRoutes) ? $matchingRoutes[0] : null;
+                $name = $io->choice('Select one of the matching routes to display its information', $matchingRoutes, $default);


I think the to display its information is not needed.

I removed this part.

Simperfit · 2018-03-21T08:51:38Z

Status: Needs Review

javiereguiluz · 2018-03-21T08:59:05Z

src/Symfony/Bundle/FrameworkBundle/Tests/Functional/RouterDebugCommandTest.php

+        $this->assertContains('/session', $display);
+    }
+
+    public function testDumpOneRoutes()


Minor typo. testDumpOneRoutes -> testDumpOneRoute

fabpot · 2018-03-21T09:59:51Z

Thank you @Simperfit.

… route (Simperfit) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] feature: add the ability to search a route | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | #26033 | License | MIT | Doc PR | symfony/symfony-docs#9236 This add the ability to search a route in the debug:router command. ![img_3271](https://user-images.githubusercontent.com/3451634/36034017-e60cbfda-0db2-11e8-841a-60bc75b0b631.jpeg) Commits ------- ef0df02 [FrameworkBundle] feature: add the ability to search a route

…a route (Simperfit) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] feature: add the ability to search for a route The PR add the documentation for core's PR symfony/symfony#26121 Commits ------- 2d781a8 feature: add the ability to search for a route

carsonbot added Status: Needs Review FrameworkBundle Feature labels Feb 9, 2018

Simperfit mentioned this pull request Feb 9, 2018

[FrameworkBundle] feature: add the ability to search for a route symfony/symfony-docs#9236

Merged

nicolas-grekas added this to the 4.1 milestone Feb 9, 2018

20uf approved these changes Feb 12, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Feb 12, 2018

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch 7 times, most recently from 3a5df79 to d002dd6 Compare February 14, 2018 12:03

carsonbot added Status: Needs Review and removed Status: Reviewed labels Feb 14, 2018

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch 2 times, most recently from 41fb042 to a9e228d Compare February 15, 2018 08:12

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch from a9e228d to 6afe696 Compare February 15, 2018 08:29

dunglas requested changes Feb 15, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Feb 15, 2018

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch from 6afe696 to 29561eb Compare February 15, 2018 08:47

stof reviewed Feb 15, 2018

View reviewed changes

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch from e30c1cd to 635ce3a Compare March 14, 2018 08:47

chalasr approved these changes Mar 20, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 20, 2018

fabpot requested changes Mar 20, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Mar 20, 2018

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch from 635ce3a to 0187162 Compare March 21, 2018 08:33

fabpot reviewed Mar 21, 2018

View reviewed changes

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch from 0187162 to 5e6007d Compare March 21, 2018 08:42

carsonbot added Status: Needs Review and removed Status: Needs Work labels Mar 21, 2018

fabpot approved these changes Mar 21, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 21, 2018

javiereguiluz approved these changes Mar 21, 2018

View reviewed changes

[FrameworkBundle] feature: add the ability to search a route

ef0df02

Simperfit force-pushed the feature/search-if-a-route-name-match-a-route-in-debug-router branch from 5e6007d to ef0df02 Compare March 21, 2018 09:40

fabpot merged commit ef0df02 into symfony:master Mar 21, 2018

Simperfit deleted the feature/search-if-a-route-name-match-a-route-in-debug-router branch March 21, 2018 10:20

fabpot mentioned this pull request May 7, 2018

Release v4.1.0-BETA1 #27181

Merged

		* The `container.service_locator` tag of `ServiceLocator`s is now autoconfigured.

		* Add the ability to search a route in `debug:router`.

Uh oh!

[FrameworkBundle] feature: add the ability to search a route #26121

[FrameworkBundle] feature: add the ability to search a route #26121

Uh oh!

Conversation

Simperfit commented Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Simperfit commented Feb 9, 2018

Uh oh!

dunglas commented Feb 9, 2018

Uh oh!

Simperfit commented Feb 12, 2018

Uh oh!

Simperfit commented Feb 14, 2018

Uh oh!

Simperfit commented Feb 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chalasr commented Mar 6, 2018

Uh oh!

althaus commented Mar 8, 2018

Uh oh!

Simperfit commented Mar 14, 2018

Uh oh!

Simperfit commented Mar 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Simperfit commented Mar 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Simperfit commented Mar 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabpot commented Mar 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Simperfit commented Feb 9, 2018 •

edited

Loading