Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security][Validator] Add translations for Tagalog#26130

Closed
ergiegonzaga wants to merge 3 commits into
symfony:masterfrom
ergiegonzaga:master
Closed

[Security][Validator] Add translations for Tagalog#26130
ergiegonzaga wants to merge 3 commits into
symfony:masterfrom
ergiegonzaga:master

Conversation

@ergiegonzaga
Copy link
Copy Markdown
Contributor

@ergiegonzaga ergiegonzaga commented Feb 10, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Why failed?

@javiereguiluz
Copy link
Copy Markdown
Member

javiereguiluz commented Feb 10, 2018

@ergiegonzaga there is a minor problem in one of the XML files. This is how you can solve it:

  1. Open the src/Symfony/Component/Validator/Resources/translations/validators.tl.xlf file.
  2. Remove the + contained at the beginning of each line.
  3. Save the changes, commit the changes (git commit src/Symfony/Component/Validator/Resources/translations/validators.tl.xlf) and push the changes.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Ahh okay sir , thanks

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Sir? why does it failed again this time? what's the problem?

@javiereguiluz
Copy link
Copy Markdown
Member

javiereguiluz commented Feb 10, 2018

@ergiegonzaga there are some problems which are unrelated to your changes ... but there's still a super minor problem with your pull request. The last line of the validators.tl.xlf file contains an extra + at the beginning of the line.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

okay sir i'll look at it now.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Sir, why does it failed again? I already removed the last (+) sign.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Hi! can someone help me on why does my pull request fails ?
Thank you.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Hi! can someone help me on why does my pull request fails ?
Thank you.

eXtreme
eXtreme reviewed Feb 10, 2018
View reviewed changes
Comment thread src/Symfony/Component/Validator/Resources/translations/validators.tl.xlf Outdated
</trans-unit>
<trans-unit id="55">
<source>This collection should contain {{ limit }} element or less.|This collection should contain {{ limit }} elements or less.</source>
<target>Ang koleksyon na ito ay dapat magkaroon ng {{ limit }} elemento o maliit pa.|Ang koleksyon na ito ay dapat magkaroon ng {{ limit }} mga elemento o maliit pa.<</target>
Copy link
Copy Markdown
Contributor

@eXtreme eXtreme Feb 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ergiegonzaga remove extra < from <</target>

Copy link
Copy Markdown
Contributor Author

@ergiegonzaga ergiegonzaga Feb 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, thanks sir, I did't really see that one.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 10, 2018

Someone help me please with the error on my pull request..

@nicolas-grekas nicolas-grekas mentioned this pull request Feb 11, 2018
Closed
@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Feb 11, 2018
@nicolas-grekas nicolas-grekas force-pushed the master branch 2 times, most recently from d82ea36 to 2fb88e5 Compare February 11, 2018 10:45
@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Feb 11, 2018 •
edited
Loading

@ergiegonzaga good news, I rebased and squashed your PR on latest master (using the git rebase -i command) and this is now green.

@nicolas-grekas nicolas-grekas changed the title Created Tagalog translations for Validator and Security [Security][Validator] Add translations for Tagalog Feb 11, 2018
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 11, 2018
Closed
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Feb 11, 2018

@nicolas-grekas Translations should always be merged in the lowest maintained branch (2.7 right now) even if some translations don't exist in 2.7.

nicolas-grekas
nicolas-grekas approved these changes Feb 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for 2.7

chalasr
chalasr requested changes Feb 11, 2018
View reviewed changes
Comment thread src/Symfony/Component/Security/Core/Resources/translations/security.tl.xlf
<trans-unit id="7">
<source>Invalid CSRF token.</source>
<target>Hindi balidong mga token ng CSRF.</target>
</trans-unit>
Copy link
Copy Markdown
Member

@chalasr chalasr Feb 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

number 8 is missing https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Security/Core/Resources/translations/security.en.xlf#L33 , required for 2.7

Copy link
Copy Markdown
Contributor Author

@ergiegonzaga ergiegonzaga Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir, I already added the missing trans-unit #8 ...

@chalasr chalasr modified the milestones: 4.1, 2.7 Feb 12, 2018
@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 12, 2018

Hi sir,I already updated the security.tl.xlf and added trans #8 .

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 12, 2018

sir? why does the (continuous-integration/appveyor/pr ) failed ?

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 12, 2018

Please someone, help me with the error..

@eXtreme
Copy link
Copy Markdown
Contributor

eXtreme commented Feb 12, 2018

@ergiegonzaga looking at other pending PRs, this failure seems not to be related to your changes so you shouldn't be worried.

@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 12, 2018

aww okay sir, ill just wait for the project owner to review my pull request..

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Feb 12, 2018

You did great! Thank you @ergiegonzaga.

fabpot added a commit that referenced this pull request Feb 12, 2018
@fabpot
minor #26130 [Security][Validator] Add translations for Tagalog (ergi…
5a70b15 
…egonzaga)

This PR was submitted for the master branch but it was squashed and merged into the 2.7 branch instead (closes #26130).

Discussion
----------

[Security][Validator] Add translations for Tagalog

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   |no
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

60abeca [Security][Validator] Add translations for Tagalog
@fabpot fabpot closed this Feb 12, 2018
@ergiegonzaga
Copy link
Copy Markdown
Contributor Author

ergiegonzaga commented Feb 12, 2018

Thank you sir, what other files I could translate into tagalog sir?

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Feb 12, 2018

There are some more translations under src/Symfony/Component/Form/Resources/translations/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalasr chalasr chalasr requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer

@eXtreme eXtreme eXtreme left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Status: Needs Work

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

7 participants

@ergiegonzaga @javiereguiluz @nicolas-grekas @fabpot @eXtreme @chalasr @carsonbot