[Bridge\PhpUnit] Cleanup BC layer #26139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ad47e5 to
bfb8969
Compare
bfb8969 to
c41681c
Compare
Tobion
approved these changes
Feb 11, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Feb 11, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Bridge\PhpUnit] Cleanup BC layer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #26024 Commits ------- c41681c [Bridge\PhpUnit] Cleanup BC layer
|
I got a Fatal error: Class 'PHPUnit\Framework\BaseTestListener' not found in /home/travis/build/doctrine/dbal/vendor/symfony/phpunit-bridge/SymfonyTestsListener.php on line 31after #26024. This should fix it? |
|
@carusogabriel please confirm :) |
|
@nicolas-grekas Another error: Class 'Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7' not foundBut now I believe is something that I need to do there, right? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #26024