[DI] Move "include_once" out of closure factories #26148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8de61b3 to
bbcd3d7
Compare
What does it fix? And if it's a bug fix shouldn't it go into older branches? |
|
It's performance bug fix for a feature that is in master only, follow up of #25867 |
Tobion
approved these changes
Feb 12, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Feb 12, 2018
…-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [DI] Move "include_once" out of closure factories | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - They were previously dumped inside the closures. Commits ------- bbcd3d7 [DI] Move "include_once" out of closure factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were previously dumped inside the closures.