Added support for name on the unit node #26149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 14, 2018
fabpot
approved these changes
Feb 15, 2018
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Feb 15, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes #26149). Discussion ---------- Added support for name on the unit node | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25758 | License | MIT | Doc PR | na See [unit specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#unit) and [name specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#name) Commits ------- 30a22aa Added support for name on the unit node
|
Thank you for merging |
symfony-splitter
pushed a commit
to symfony/translation
that referenced
this pull request
Mar 30, 2018
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in symfony/symfony#26149 Commits ------- ca41fecfd9 Make sure to trim source if it is too long
fabpot
added a commit
that referenced
this pull request
Mar 30, 2018
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in #26149 Commits ------- ca41fec Make sure to trim source if it is too long
Merged
|
Any specific reason this hasn't been merge in 3.4 ? |
|
Excellent question. Yes, there is a reason. This was a new feature. 3.4 will not include new features, only bug fixes and security fixes. Symfony is using version numbers like x.y.z. X is a major change (can break BC). Y is added features. Z is bug fixes. You can read more about Semver here: https://semver.org/ You can also see Symfonys release process here: https://symfony.com/releases |
|
Thanks for the answer, I was preparing a PR to report it to 3.4 but it won't be accepted if I understand. We should definitly move to 4.4... |
SerhiyMytrovtsiy
added a commit
to SerhiyMytrovtsiy/translation
that referenced
this pull request
Oct 19, 2022
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in symfony/symfony#26149 Commits ------- ca41fecfd9 Make sure to trim source if it is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See unit specification and name specification