Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Add missing XML config for circular_reference_handler #26234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

[FrameworkBundle] Add missing XML config for circular_reference_handler #26234

merged 1 commit into from
Feb 19, 2018

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Feb 19, 2018 •
edited
Loading

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@dunglas dunglas requested a review from lyrixx February 19, 2018 15:04
@dunglas dunglas changed the title [FrameworkBundle] Add missing XML config for circular_reference_handl… [FrameworkBundle] Add missing XML config for circular_reference_handler Feb 19, 2018
@dunglas dunglas removed the BC Break label Feb 19, 2018
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 19, 2018
nicolas-grekas
nicolas-grekas approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for 3.4 (3.3 is EOLed)

@dunglas dunglas changed the base branch from 3.3 to 3.4 February 19, 2018 18:11
@dunglas dunglas force-pushed the fix-xml-circular_reference_handler branch 2 times, most recently from ca6bb3e to 611ff59 Compare February 19, 2018 18:14
@fabpot
Copy link
Member

fabpot commented Feb 19, 2018

Thank you @dunglas.

@fabpot fabpot merged commit 611ff59 into symfony:3.4 Feb 19, 2018
fabpot added a commit that referenced this pull request Feb 19, 2018
@fabpot
bug #26234 [FrameworkBundle] Add missing XML config for circular_refe…
349f704 
…rence_handler (dunglas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Add missing XML config for circular_reference_handler

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

* Add missing XML config for circular_reference_handler (#22011)
* Add tests

Commits
-------

611ff59 [FrameworkBundle] Add missing XML config for circular_reference_handler. Add tests.
@dunglas dunglas deleted the fix-xml-circular_reference_handler branch February 19, 2018 20:47
This was referenced Mar 1, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@lyrixx lyrixx lyrixx approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@dunglas @fabpot @nicolas-grekas @lyrixx @Simperfit @carsonbot