[Serializer] Pass the serializer context to PropertyTypeExtractorInterface #26235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't we merge something similar as bug fix recently? |
|
In #26043 actually |
|
It's not the same. In this one the idea is to give access to the serialization context in the PropertyInfo component. |
|
Ok :) what about adding a test case? |
|
bof 😋 (i'll add it) |
|
If we don't have an actual use case, i'd rather not do this since it makes caching much harder (values of circular reference fields are dynamic, aren't they?). I think it was already rejected in the past because of this. |
|
Indeed it's bad in term of cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rface