[Security][Profiler] Display the original expression in 'Access decision log' #26273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4f3ae7 to
c2d42ae
Compare
|
I suggest also adding my patch from #24127 (comment) (the second one), to use We might even consider this as a bugfix. |
stof
requested changes
Feb 22, 2018
| {{ decision.attributes|first }} | ||
| {% set first = decision.attributes|first %} | ||
| {% if first.expression is defined %} | ||
| Expression: <code><pre>{{ first.expression }}</pre></code> |
There was a problem hiding this comment.
should be <pre><code></code></pre> as <code> is an inline element while <pre> is a block element.
c2d42ae to
afcd558
Compare
|
@stof I addressed your comments. |
Simperfit
approved these changes
Feb 23, 2018
|
Looks like a bug fix to me, no? |
afcd558 to
8f16c2e
Compare
|
I have rebased my branch onto 3.4, and changed the base branch for this PR in order to merge it as a bug fix. |
nicolas-grekas
approved these changes
Mar 19, 2018
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 19, 2018
…ccess decision log' (lyrixx) This PR was merged into the 3.4 branch. Discussion ---------- [Security][Profiler] Display the original expression in 'Access decision log' | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24127 | License | MIT | Doc PR | --- before:  after:  Commits ------- 8f16c2e [Security][Profiler] Display the original expression in 'Access decision log'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after: