[Config] Introduce BuilderAwareInterface#26308
Closed
ro0NL wants to merge 3 commits into
Closed
Conversation
| namespace Symfony\Component\Config\Definition\Builder; | ||
|
|
||
| /** | ||
| * An interface that can be implemented by nodes which built other nodes. |
20uf
approved these changes
Mar 6, 2018
Simperfit
reviewed
Mar 6, 2018
| interface BuilderAwareInterface | ||
| { | ||
| /** | ||
| * Sets a custom children builder. |
Contributor
There was a problem hiding this comment.
is this really needed :p ?
Contributor
There was a problem hiding this comment.
It can be just comment, and not phpdoc IMHO.
Contributor
Author
There was a problem hiding this comment.
I only moved things around, https://github.com/symfony/symfony/pull/26335/files#diff-b579be54110e0018ae82a55725bc373fL49
works for me as is :)
Member
There was a problem hiding this comment.
We use phpdoc for documenting methods, not wild comments. So it's either a docblock or nothing at all, personally I would remove it as it does not bring much IMHO.
Simperfit
approved these changes
Mar 6, 2018
Contributor
Simperfit
left a comment
There was a problem hiding this comment.
with a really minor comment ^^.
chalasr
approved these changes
Mar 7, 2018
Member
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 19, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes #26308). Discussion ---------- [Config] Introduce BuilderAwareInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Split `ParentNodeDefinitionInterface` into `BuilderAwareInterface`. Use case is custom node definition (extended from VariableNodeDef) with a corresponding prototyped array node. To set the actual prototype i need the builder at definition level, provided by `ParentNodeDefinitionInterface`. However i don't implement `children()` + `append()`, i solely need the builder scope. To go after #26297 Commits ------- 1353694 [Config] Introduce BuilderAwareInterface
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
ParentNodeDefinitionInterfaceintoBuilderAwareInterface.Use case is custom node definition (extended from VariableNodeDef) with a corresponding prototyped array node.
To set the actual prototype i need the builder at definition level, provided by
ParentNodeDefinitionInterface. However i don't implementchildren()+append(), i solely need the builder scope.To go after #26297