Add a data_help method in Form #26332

mpiot · 2018-02-27T10:01:40Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#26331
License	MIT
Doc PR	symfony/symfony-docs#9361

Add a form_help method in twig to display a help message in form. A help keyword is added to all FormType to define the message.

stof

This is missing tests

stof · 2018-02-27T10:29:34Z

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

+
+{% block form_help -%}
+    {% if form.vars.help is not empty %}
+        <small class="form-text text-muted">{{ form.vars.help|raw }}</small>


displaying it raw is a bad idea IMO. It opens the door to XSS.

Mmm, is it really a problem ? Because it's set in the FormType by the dev, not by a user. Then, if we want use html in the help text without raw, we can't. I don't really know

Well, requiring to perform HTML escaping when setting the option is insecure IMO. It requires all devs to be aware that this options requires escaping when setting it. And it might totally be set based on some user input (coming from a previous configuration elsewhere) in some cases.

Btw, I would add translation support for the help text instead of requiring to translate it in the form type when setting the option.

Ok, I remove it from Symfony, if someone want to change it, just to extend the Template and add the raw.

By translation you mean use |trans in Twig ?

yes, as done for labels or other things

stof · 2018-02-27T10:29:40Z

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

+{# Help #}
+
+{% block form_help -%}
+    {% if form.vars.help is not empty %}


just help

Thx for the shortcut, I edit it

mpiot · 2018-02-27T10:39:47Z

Yes, I fix existing tests, and wite new (I've never do it, it take a little times, sorry...)

Nyholm

Great. Thank you for contributing this.

Nyholm · 2018-02-27T13:15:59Z

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

+
+{% block form_help -%}
+    {% if help is not empty %}
+        <small class="form-text text-muted">{{ help|trans }}</small>


Let's make sure it respects the translation domain.

{{ translation_domain is same as(false) ? help : help|trans({}, translation_domain) }}

Okay, I edit it. (I don't really know what is it, but I trust you ;-))

It checks if translation_domain is false, it it is we just print help. If it is not false we use translation with that domain.

I was thinking about TranslationDomain, I don't know what it is, I'd watch.

Have a look here: http://symfony.com/doc/current/components/translation.html#using-message-domains

It is basically a way to categorize translation messages.

Make sure you add this fix every time you print help. (ie in the form_div_layout.html.twig)

Thanks, and it's done :-) (it's interresting to do PR, it permit to learn lot of things:-))

mpiot · 2018-02-27T13:32:37Z

Just a question, how can I execute tests ? Because when I do:

COMPOSER_ROOT_VERSION=4.0 composer install
vendor/bin/simple-phpunit src/Symfony/Bridge/Twig/Tests

It return to me alle is ok, but Skip a lot of tests, but in TravisCi, it doesn't skip test and there is a lot of error, I can't try and push everytime to see what say Travis :-(

I've try to do something like travis do:

cd src/Symfony/Bridge/Twig
composer update --no-progress --ansi --prefer-lowest --prefer-stable
SYMFONY_ROOT_DIR/phpunit --exclude-group tty,benchmark,intl-data

But it does less tests, Skip all, and thrw an exception:

Other deprecation notices (1)
1x: The each() function is deprecated. This message will be suppressed on further calls

Thanks a lot, and sorry, it's the first tim I'm looking into tests... (I know, it's wrong... :p)

Nyholm · 2018-02-27T13:37:34Z

I usually do ./phpunit src/Symfony/Bridge/Twig. That should not skip the tests.

Here is a page that describes this in details: https://symfony.com/doc/current/contributing/code/tests.html

Nyholm · 2018-02-27T13:42:38Z

Btw, I see that it is the "deps low" test that fails on Travis. That is okey for this PR since the changes on the different components depends on each other.

mpiot · 2018-02-27T13:45:11Z

Oki, but I thought it would be nice to add tests for the new elements, right?

Test the form_help output, and then, maybe it change something form the form_row, no ?

Nyholm · 2018-02-27T13:46:39Z

That would be excellent.

javiereguiluz · 2018-02-27T13:58:27Z

I'm pinging some of our biggest Symfony Form experts so they can double check these changes: @HeahDude, @vudaltsov, @yceruto Thanks!

mpiot · 2018-02-27T14:03:44Z

Thank you :-)
Because I'm not very comfortable with Symfony Form, I'm just discovering the insides.

vudaltsov

Great PR, I like it.
Since we support Foundation framework, we should probably add form_help there too.

Nyholm · 2018-02-28T18:04:01Z

Excellent. This looks real good.

(Bootstrap 4):

There is one thing I'm missing. You need to add an id to the help block (id="{{id}}_help) and use the aria-describedby on the <input>.

<label for="inputPassword5">Password</label>
<input type="password" id="inputPassword5" class="form-control" aria-describedby="passwordHelpBlock">
<small id="passwordHelpBlock" class="form-text text-muted">
  Your password must be 8-20 characters long, contain letters and numbers, and must not contain spaces, special characters, or emoji.
</small>

mpiot · 2018-02-28T18:31:27Z

@Nyholm I fix it tomorrow :-)

Nyholm · 2018-03-01T07:01:53Z

Good. We also need the the aria-describedby on the .

After that I’m very happy.

mpiot · 2018-03-01T07:09:41Z

@Nyholm This is done, just a little reflexion to avoid add the aria-describedBy, when there is not helpBlock. And some difficulties in the FrameworkBundle views, I don't know wwhat is its usage, but I don't like it :p

Nyholm

Good job. I did a much more thorough review now.

Could you also make sure fabbot is happy?

Nyholm · 2018-03-01T08:04:47Z

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

+
+{% block form_help -%}
+    {% if help is not empty %}
+        <small id="{{ id }}HelpBlock" class="form-text text-muted">{{ translation_domain is same as(false) ? help : help|trans({}, translation_domain) }}</small>


id generated by symfony is snake_case. I suggest changing this to {{ id }}_help

Nyholm · 2018-03-01T08:07:35Z

src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig

@@ -297,7 +305,8 @@
    <div>
        {{- form_label(form) -}}
        {{- form_errors(form) -}}
-        {{- form_widget(form) -}}
+        {{- form_widget(form, { 'helpBlockDisplayed': true }) -}}


Couldn't we check if help is not empty here?
That would make the logic in widget_attributes simpler

The problem is when a user just display form_widget for exemple, the form_help is not call, then we don't have to display the aria-describedBy, because the block doesn't exists.

That's why I do the test later, else, user say if he declare the form_help to do the link between help block and input.

In the row, I do it automatically, because I'm sure the help block is displayed.

I see. Could we try something like:

{{- form_widget(form, { 'helpBlockDisplayed': (help is not empty) }) -}} or that may be a syntax error.

It's the same problem, we can't do it automatically, the help may be set, but don't displayed if the user do:

{{ form_label(form.name) }} {{ form_errors(form.name) }} {{ form_widget(form.name) }}

He doesn't call form_label, then help is not displayed, but set in the form.

Yeah, But it that a problem?

If the user do:

{{ form_label(form.name) }} {{ form_errors(form.name) }} {{ form_widget(form.name) }}

Then no form help will be rendered and no aria-describedBy will be used.

If the user do:

{{ form_label(form.name) }} {{ form_errors(form.name) }} {{ form_widget(form.name) }} {{ form_help(form.name) }}

Then form help will be rendered but no aria-describedBy will be used.

We should only make sure that the logic is clean and when the user do:

{{ form_row(form.name) }}

Then form help will be rendered AND aria-describedBy will be used.

Yes, we can do that, I've do it to permit the user to add the aria-describedBy when don't use form_row. Then, I'm not really sure it's the best way to do, the method must work for all.

Nyholm · 2018-03-01T08:08:28Z

src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig

@@ -384,6 +393,7 @@
    id="{{ id }}" name="{{ full_name }}"
    {%- if disabled %} disabled="disabled"{% endif -%}
    {%- if required %} required="required"{% endif -%}
+    {%- if helpBlockDisplayed is defined and helpBlockDisplayed and help is not empty %} aria-describedby="{{ id }}HelpBlock"{% endif -%}


Replace and helpBlockDisplayed and with and helpBlockDisplayed same as(true) and

Nyholm · 2018-03-01T08:09:17Z

src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/form_help.html.php

@@ -0,0 +1,3 @@
+<?php if (!empty($help)): ?>
+    <p id="<?php echo $view->escape($id) ?>HelpBlock" class="help-text"><?php echo $view->escape(false !== $translation_domain ? $view['translator']->trans($help, array(), $translation_domain) : $help) ?></p>


_help instead of HelpBlock

Nyholm · 2018-03-01T08:10:01Z

src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/widget_attributes.html.php

@@ -1,3 +1,4 @@
 id="<?php echo $view->escape($id) ?>" name="<?php echo $view->escape($full_name) ?>"<?php if ($disabled): ?> disabled="disabled"<?php endif ?>
 <?php if ($required): ?> required="required"<?php endif ?>
-<?php echo $attr ? ' '.$view['form']->block($form, 'attributes') : '' ?>
+<?php if (isset($helpBlockDisplayed) && $helpBlockDisplayed && !empty($help)): ?> aria-describedby="<?php echo $view->escape($id) ?>HelpBlock"<?php endif ?>


&& $helpBlockDisplayed && => && true === $helpBlockDisplayed &&

Nyholm · 2018-03-01T08:12:00Z

src/Symfony/Component/Form/Extension/Core/Type/FormType.php

@@ -177,10 +178,12 @@ public function configureOptions(OptionsResolver $resolver)
            'attr' => array(),
            'post_max_size_message' => 'The uploaded file was too large. Please try to upload a smaller file.',
            'upload_max_size_message' => $uploadMaxSizeMessage, // internal
+            'help' => '',


Should the default be an empty string or null? Spontaneously I would say null, but Im sure there is a reason you chose the empty string.

I've not test with null... But In the line bellow, we must define the accepted type that is string. That's why I've put an empty string. But Maybe it works well with null, I can try it. Tests will scream if it's not good.

I confirm, if default is null, it trhown error because it expect a string value.

Okey, Could we make it expect a string value and null? Or maybe false would make more sense.

I can try if I can give him an array of possibilities, but I don't know if it works, I don't know this part of the code.

It's okay :-)

$resolver->setAllowedTypes('help', ['string', 'NULL']);

Nyholm · 2018-03-01T08:12:12Z

src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php

+
+        $this->assertMatchesXpath($html,
+'/span
+    [@id="nameHelpBlock"]


Nyholm · 2018-03-01T08:12:22Z

src/Symfony/Component/Form/Tests/AbstractLayoutTest.php

+
+        $this->assertMatchesXpath($html,
+'/p
+    [@id="nameHelpBlock"]


mpiot · 2018-03-01T08:43:43Z

@Nyholm I've fixed some of your suggestions :-) Mmm, "Could you also make sure fabbot is happy?", how I do that ? :p

Nyholm · 2018-03-01T08:54:11Z

Thanks!

Fabbot is a script that make sure all PRs follow code standard and it also runs some test for "common things". It is real great.

See the PR status.

You see that there are some things fabbot complains about. Just copy the command and fabbot will fix things for you.

mpiot · 2018-03-01T08:58:35Z

Oh yes, I've see that, but the correction, isn't the way used in all the other files... That's why I've not fix it and keep the way used in existing files.

Nyholm · 2018-03-01T09:02:19Z

No, you can trust the fabbot. It does only correct/review the files you've edited in this PR.

mpiot · 2018-03-01T09:09:06Z

For exemple it say to fix:

<?php echo $view['form']->label($form) ?>
<?php echo $view['form']->errors($form) ?>
<?php echo $view['form']->widget($form, array('helpBlockDisplayed' => true)) ?>
<?php echo $view['form']->help($form) ?>

By:

<?php echo $view['form']->label($form); ?>
<?php echo $view['form']->errors($form); ?>
<?php echo $view['form']->widget($form, array('helpBlockDisplayed' => true)); ?>
<?php echo $view['form']->help($form); ?>

I've not edited other lines, just add one. That's why I've keep the syntax without the ; at end.

It's the same everywhere, it want to add ; at end of each php block, but it's actually used nowhere in the folder src/Symfony/Bundle/FrameworkBundle/Ressources/views/Form. That's why I don't really know if I must do like fabpot.io say or do like all files are.

Nyholm · 2018-03-01T09:12:27Z

I guess fabbot has updated its rules since those other lines were added. I think we should follow the recommendations by fabbot in this case.

Nyholm

Could you also run the following to fix the license in the file headers:

curl https://fabbot.io/patch/symfony/symfony/26332/80c66414450cbf0148d4fac6288c83a8b72172ae/license.diff | patch -p0

Nyholm · 2018-03-01T10:15:29Z

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig

@@ -92,6 +92,7 @@
    <div class="form-group{% if (not compound or force_error|default(false)) and not valid %} has-error{% endif %}">
        {{- form_label(form) -}}
        {{- form_widget(form) -}}


We should make sure aria-describedby is enabled here

Nyholm · 2018-03-01T10:17:28Z

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

@@ -218,6 +218,7 @@
    <{{ element|default('div') }} class="form-group">
        {{- form_label(form) -}}
        {{- form_widget(form) -}}


We should make sure aria-describedby is enabled here

Nyholm · 2018-03-01T10:18:00Z

src/Symfony/Bridge/Twig/Resources/views/Form/foundation_5_layout.html.twig

@@ -271,6 +271,7 @@
        <div class="large-12 columns{% if (not compound or force_error|default(false)) and not valid %} error{% endif %}">
            {{ form_label(form) }}
            {{ form_widget(form) }}


We should make sure aria-describedby is enabled here

mpiot · 2018-03-01T10:48:50Z

It bugs.... The diff is empty, the diff file doesn't exists and I've already apply the patch to add the licence header.

…cessary.

fabpot · 2018-03-27T07:25:15Z

Thank you @mpiot.

This PR was merged into the 4.1-dev branch. Discussion ---------- Add a data_help method in Form | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26331 | License | MIT | Doc PR | symfony/symfony-docs#9361 Add a form_help method in twig to display a help message in form. A `help` keyword is added to all FormType to define the message. Commits ------- 585ca28 Add return type hint 859ee03 Revert: remove comment line from twig templates d723756 Fix some mistakes c74e0dc Use spaceless balises in Twig templates 8b937ff Try without try/catch 32bf1f6 Test the renderHelp method in all Tests about help to skip them if necessary. 437b77e Skip renderHelp test as skipped if not override d84be70 Update composer files 075fcfd [FrameworkBundle] Add widgetAtt to formTable/form_row f1d13a8 Fix Fabpot.io 69ded67 Added form_help on horizontal design and removed special variable fd53bc5 Enable aria-described in row for all Templates 98065d3 fabpot.io fix edb95f8 Use array long syntax aada72c Set help option on nul as default f948147 Rename help id (snake_case) 77fa317 Fix Test 30deaa9 PSR fix bf4d08c Add aria-describedBy on input 1f3a15e Rename id 058489d Add an id to the help 6ea7a20 Remove vars option from form_help ba798df FrameworkBundle Tests 4f2581d Use array long syntax f15bc79 Fix coding standards c934e49 Add test without help set 8094804 Add Tests 067c681 Template for table, Foundation and Bootstrap 3 d3e3e49 Fix: check translation domain 2c2c045 Adapt existant tests 831693a Add trans filter e311838 Remove raw filter for help 8b97c1b Use a shortcut to acces help var in Twig template 1b89f9d Add a template fot div_layout c8914f5 Add a data_help method in Form

This PR was squashed before being merged into the 4.1 branch (closes #9361). Discussion ---------- Add help option to FormType Add documentation about the new feature symfony/symfony#26332 Commits ------- 5bdf708 Add help option to FormType

mhujer · 2018-05-27T10:15:54Z

Maybe this should be added to UPGRADE-4.1.md as well? Because when you have your own Form Type Extension to handle help attribute, it starts to render twice in the form.

nicolas-grekas · 2018-05-27T11:37:28Z

Would you like to open this PR?

This PR was merged into the 4.1 branch. Discussion ---------- [Form] mention "help" field option in UPGRADE file | Q | A | ------------- | --- | Branch? | 4.1  | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #...  | License | MIT When you have your own Form Extension to handle help option (e.g. similar to the one mentioned in the [blog post](https://symfony.com/blog/new-in-symfony-4-1-form-field-help)), it starts to render twice in the form after upgrading to 4.1 (where #26332 was added)  Commits ------- 744362a update UPGRADE-4.1 for feature #26332 Form field help option

* 4.1: (22 commits) [HttpKernel] Fix restoring trusted proxies in tests Update UPGRADE-4.0.md [Messenger] Fix suggested enqueue adapter package bumped Symfony version to 4.1.1 updated VERSION for 4.1.0 updated CHANGELOG for 4.1.0 Insert correct parameter_bag service in AbstractController Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)" CODEOWNERS: some more rules removed unneeded comments in tests removed unneeded comments in tests Change PHPDoc in ResponseHeaderBag::getCookies() to help IDEs [HttpKernel] fix registering IDE links update UPGRADE-4.1 for feature #26332 Form field help option [HttpKernel] Set first trusted proxy as REMOTE_ADDR in InlineFragmentRenderer. [Process] Consider \"executable\" suffixes first on Windows Triggering RememberMe's loginFail() when token cannot be created bumped Symfony version to 4.1.0 updated VERSION for 4.1.0-BETA3 updated CHANGELOG for 4.1.0-BETA3 ...

loru88 · 2018-06-19T10:15:13Z

Do you think it's possible to have this feature available also in Symfony 3.4?
I can't understand why this simple feature is stick just to Symfony 4

xabbuh · 2018-06-19T11:51:35Z

@loru88 We never add new features in patch versions, but only do that in minor releases. You can read more about our release process at http://symfony.com/doc/current/contributing/community/releases.html.

carsonbot added Status: Needs Review Feature labels Feb 27, 2018

stof reviewed Feb 27, 2018

View reviewed changes

Nyholm reviewed Feb 27, 2018

View reviewed changes

nicolas-grekas added this to the 4.1 milestone Feb 27, 2018

vudaltsov suggested changes Feb 27, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Feb 27, 2018

mpiot mentioned this pull request Feb 28, 2018

Add help option to FormType symfony/symfony-docs#9361

Closed

Nyholm requested changes Mar 1, 2018

View reviewed changes

mpiot added 8 commits March 23, 2018 15:53

Update composer files

d84be70

Skip renderHelp test as skipped if not override

437b77e

Test the renderHelp method in all Tests about help to skip them if ne…

32bf1f6

…cessary.

Try without try/catch

8b937ff

Use spaceless balises in Twig templates

c74e0dc

Fix some mistakes

d723756

Revert: remove comment line from twig templates

859ee03

Add return type hint

585ca28

carsonbot added Status: Needs Review and removed Status: Reviewed labels Mar 27, 2018

fabpot approved these changes Mar 27, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 27, 2018

fabpot merged commit 585ca28 into symfony:master Mar 27, 2018

mpiot deleted the form_help branch March 29, 2018 19:50

fabpot mentioned this pull request May 7, 2018

Release v4.1.0-BETA1 #27181

Merged

mhujer added a commit to mhujer/symfony that referenced this pull request May 27, 2018

update UPGRADE-4.1 for feature symfony#26332 Form field help option

888a2f2

mhujer mentioned this pull request May 27, 2018

[Form] mention "help" field option in UPGRADE file #27393

Merged

mhujer added a commit to mhujer/symfony that referenced this pull request May 27, 2018

update UPGRADE-4.1 for feature symfony#26332 Form field help option

744362a

xabbuh mentioned this pull request Jun 4, 2018

Symfony 4.1 twig error : Variable "help" does not exist #27489

Closed

xabbuh mentioned this pull request Jun 30, 2018

[Form][TwigBridge] Add help_attr #27043

Merged

		@@ -0,0 +1,3 @@
		<?php if (!empty($help)): ?>
		<p id="<?php echo $view->escape($id) ?>HelpBlock" class="help-text"><?php echo $view->escape(false !== $translation_domain ? $view['translator']->trans($help, array(), $translation_domain) : $help) ?></p>

Add a data_help method in Form #26332

Add a data_help method in Form #26332

Conversation

mpiot commented Feb 27, 2018 • edited Loading

stof left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stof Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

mpiot Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

mpiot commented Feb 27, 2018 • edited Loading

Nyholm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nyholm Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

mpiot Feb 27, 2018 • edited Loading

Choose a reason for hiding this comment

mpiot commented Feb 27, 2018

Nyholm commented Feb 27, 2018

Nyholm commented Feb 27, 2018

mpiot commented Feb 27, 2018

Nyholm commented Feb 27, 2018

javiereguiluz commented Feb 27, 2018

mpiot commented Feb 27, 2018

vudaltsov left a comment

Choose a reason for hiding this comment

Nyholm commented Feb 28, 2018

mpiot commented Feb 28, 2018 • edited Loading

Nyholm commented Mar 1, 2018

mpiot commented Mar 1, 2018

Nyholm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot commented Mar 1, 2018

Nyholm commented Mar 1, 2018

mpiot commented Mar 1, 2018 • edited Loading

Nyholm commented Mar 1, 2018

mpiot commented Mar 1, 2018

Nyholm commented Mar 1, 2018

Nyholm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpiot commented Mar 1, 2018

fabpot commented Mar 27, 2018

mhujer commented May 27, 2018

nicolas-grekas commented May 27, 2018

mpiot commented Feb 27, 2018 •

edited

Loading

stof Feb 27, 2018 •

edited

Loading

mpiot Feb 27, 2018 •

edited

Loading

mpiot Feb 27, 2018 •

edited

Loading

mpiot commented Feb 27, 2018 •

edited

Loading

Nyholm Feb 27, 2018 •

edited

Loading

mpiot Feb 27, 2018 •

edited

Loading

mpiot commented Feb 28, 2018 •

edited

Loading

mpiot Mar 1, 2018 •

edited

Loading

mpiot Mar 1, 2018 •

edited

Loading

mpiot Mar 1, 2018 •

edited

Loading

mpiot Mar 1, 2018 •

edited

Loading

mpiot commented Mar 1, 2018 •

edited

Loading