Autoconfigure service locator tag #26341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 28, 2018
derrabus
requested changes
Feb 28, 2018
| @@ -6,6 +6,7 @@ CHANGELOG | |||
|
|
|||
| * added support for variadics in named arguments | |||
| * added PSR-11 `ContainerBagInterface` and its `ContainerBag` implementation to access parameters as-a-service | |||
| * The `container.service_locator` tag of `ServiceLocator`s is now autoconfigured. | |||
There was a problem hiding this comment.
This should go into the ChangeLog of FrameworkBundle, not the DI component.
There was a problem hiding this comment.
Ah, you are correct! I was confused by the path of the FrameworkExtension. Is fixed.
derrabus
approved these changes
Feb 28, 2018
Simperfit
approved these changes
Feb 28, 2018
chalasr
approved these changes
Feb 28, 2018
Nyholm
approved these changes
Mar 1, 2018
|
Thank you @apfelbox. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now also autoconfigure the (required) tag
container.service_locatorfor allServiceLocators.I couldn't find any integration tests for the whole list of autoconfigured core services, so I didn't add any new tests.