[DI] Fix missing "id" normalization when dumping the container #26355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 1, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26306 |
| License | MIT |
| Doc PR | - |
9c32b1e to
62e044d
Compare
stof
requested changes
Mar 1, 2018
62e044d to
1496cbf
Compare
|
I'm not able to write tests for all the situations that where missing normalization of references. |
90e4256 to
24d4d54
Compare
b69bf27 to
c93bf76
Compare
c93bf76 to
4a5e43e
Compare
|
Now with a test case that covers the reported issue, and with µ-optimizations found meanwhile, following reports of noticeable CPU usage in (env)parameters resolving. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 2, 2018
…iner (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix missing "id" normalization when dumping the container | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26306 | License | MIT | Doc PR | - Commits ------- 4a5e43e [DI] Fix missing "id" normalization when dumping the container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.