[WebProfilerBundle] Display the Missing translations tab by default if there are missing translations #26394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tend to agree to treat this as a bugfix, since the behaviour seems better than before. |
ro0NL
reviewed
Mar 4, 2018
| @@ -338,13 +338,14 @@ | |||
| var tabNavigation = document.createElement('ul'); | |||
| tabNavigation.className = 'tab-navigation'; | |||
|
|
|||
| var selectedTabId = 'tab-' + i + '-0'; /* select the first tab by default */ | |||
There was a problem hiding this comment.
does twigbundle need the same fix? file not found in 2.8... but dont forget to update it upon merge i guess ;-)
also the reason im a bit skeptical about 2.8... it's new behavior and things have changed as of 3.4. Not sure if the merge will be conflicting.. but tend to prefer 3.4 at least somehow :)
|
Definitely not a bug as there is nothing broken right now. A behavior change (@Simperfit) is a new feature and applying a bug fix to 3.4 instead of convenience (@ro0NL) makes me think this is not a bug either. |
|
Closing in favor of #26398 to add this as a new feature. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of you may consider this a new feature instead of a bug, but I thought this was a bug because the new behavior should be the behavior of this panel since day one.
The idea is to display the "Missing translations" tab selected by default ... but only when there are missing translations. Otherwise, keep displaying the "Defined translations" tab.