[CssSelector] Fix CSS identifiers parsing - they can start with dash #26450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ public function __construct() | |||
| $this->stringEscapePattern = $this->newLineEscapePattern.'|'.$this->escapePattern; | |||
| $this->nonAsciiPattern = '[^\x00-\x7F]'; | |||
| $this->nmCharPattern = '[_a-z0-9-]|'.$this->escapePattern.'|'.$this->nonAsciiPattern; | |||
| $this->nmStartPattern = '[_a-z]|'.$this->escapePattern.'|'.$this->nonAsciiPattern; | |||
| $this->nmStartPattern = '[_a-z-]|'.$this->escapePattern.'|'.$this->nonAsciiPattern; | |||
There was a problem hiding this comment.
Checking the official CSS grammar I found this:
nmstart [_a-z]|{nonascii}|{escape}
nmchar [_a-z0-9-]|{nonascii}|{escape}
ident -?{nmstart}{nmchar}*
So maybe we should move the optional starting - to $this->identifierPattern?
There was a problem hiding this comment.
Sure, fixed according to CSS grammar.
346be01 to
16e86bc
Compare
javiereguiluz
approved these changes
Mar 8, 2018
stof
approved these changes
Mar 8, 2018
|
Good catch, thanks @jakubkulhan. |
stof
added a commit
that referenced
this pull request
Mar 8, 2018
… with dash (jakubkulhan) This PR was merged into the 2.7 branch. Discussion ---------- [CssSelector] Fix CSS identifiers parsing - they can start with dash | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Vendor prefixes use `-` (dash) at the start of CSS identifiers. Commits ------- 16e86bc [CssSelector] Fix CSS identifiers parsing - they can start with dash
This was referenced Apr 2, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor prefixes use
-(dash) at the start of CSS identifiers.