[Console] rewrite autocomplete interactive mode from console #26458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b01bc8e to
ccdc979
Compare
|
Thank you @youssefbenhssaien. Could you add some tests please? |
|
This is now fixed thanks to #26875. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
Using the command make:subscriber with an event suscriber kernel.controller on the interactive mode (Responding to the 'What event do you want to subscribe to?' question).
Submited : kernel.controller
Result : kernel.controller_arguments
Console :
Result :
Bug caused by :
When puting an Enter character on the console, a last check is made to verify even the character is a new line \n or a tabulation \t, then choose the returned autocomplete from the matches array with an $ofs = 0 which return $matches[0] = 'kernel.controller_arguments on the following lines :
symfony/src/Symfony/Component/Console/Helper/QuestionHelper.php
Lines 235 to 239 in cd5f410