[PhpUnitBridge] Ability to use different composer.json file #26482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I have a project where I use a different composer.json via environment variable. Look here. Because of this, $root gets set to "/" and everything fails. Hope this helps.
fabpot
requested changes
Mar 10, 2018
| @@ -26,8 +26,10 @@ if (PHP_VERSION_ID >= 70200) { | |||
| $PHPUNIT_VERSION = '4.8'; | |||
| } | |||
|
|
|||
| COMPOSER_FILE_NAME = getenv('COMPOSER_FILE_NAME') ? : 'composer.json'; | |||
There was a problem hiding this comment.
COMPOSER_FILE_NAMEis non-standard. According to https://getcomposer.org/doc/03-cli.md#environment-variables, it should beCOMPOSER` instead.
There was a problem hiding this comment.
This should work:
if ('composer.json' !== $COMPOSER_JSON = getenv('COMPOSER') ?: 'composer.json') {
putenv('COMPOSER=composer.json');
$_SERVER['COMPOSER'] = $_ENV['COMPOSER'] = 'composer.json';
}
|
@fabpot, if we used COMPOSER as the var name, then other composer calls would fail:
I'm not sure at which point it fails, I could look in to it but I'll need some more time. Do you have any ideas why that fails? |
|
@nicolas-grekas, I can confirm it works using "COMPOSER":
I updated the PR. |
fabpot
approved these changes
Mar 13, 2018
|
Thank you @amcastror. |
fabpot
added a commit
that referenced
this pull request
Mar 13, 2018
…e (amcastror) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #26482). Discussion ---------- [PhpUnitBridge] Ability to use different composer.json file Hi, I have a project where I use a different composer.json via environment variable. Look [here](https://getcomposer.org/doc/03-cli.md#composer). Because of this, $root gets set to "/" and everything fails. Hope this helps. | Q | A | ------------- | --- | Branch? | master for features / 2.7 up to 4.0 for bug fixes <!-- see below --> | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | I'll add if this is useful. | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 77e643d [PhpUnitBridge] Ability to use different composer.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have a project where I use a different composer.json via environment variable. Look here. Because of this, $root gets set to "/" and everything fails.
Hope this helps.