Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Remove const override #26551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2018
Merged

[Serializer] Remove const override #26551

merged 1 commit into from
Mar 16, 2018

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Mar 15, 2018 •
edited
Loading

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

This public const was moved to parent class in #24816

@javiereguiluz javiereguiluz added this to the 3.4 milestone Mar 16, 2018
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 25312c4 into symfony:3.4 Mar 16, 2018
nicolas-grekas added a commit that referenced this pull request Mar 16, 2018
@nicolas-grekas
minor #26551 [Serializer] Remove const override (ogizanagi)
866a142 
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Remove const override

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

This public const was moved to parent class in #24816

Commits
-------

25312c4 [Serializer] Remove const override
@ogizanagi ogizanagi deleted the minor/serializer/remove_dup_const branch March 16, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ogizanagi @nicolas-grekas @javiereguiluz @Simperfit @carsonbot