[Routing] Fixed the importing of files using glob patterns that match multiple resources #26600
Conversation
… multiple resources
|
Failures are unrelated. Also, I didn't know which branch to target: the source of the problem is a change in |
|
@skalpa thank you. Branch 3.4 is the good one. I think |
|
@nicolas-grekas I took care of |
| $collection = $routes->collection(); | ||
|
|
||
| $collection->add('bar_route', '/bar') | ||
| ->defaults(['_controller' => 'AppBundle:Bar:view']); |
There was a problem hiding this comment.
array() instead of [] (same below, see fabbot patch)
There was a problem hiding this comment.
Sorry, old habits. Fixed.
|
Thank you @skalpa. |
… that match multiple resources (skalpa) This PR was squashed before being merged into the 3.4 branch (closes #26600). Discussion ---------- [Routing] Fixed the importing of files using glob patterns that match multiple resources | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22160 | License | MIT | Doc PR | n/a This fixes the import of resources specified using glob patterns in `XmlFileLoader` and `YamlFileLoader`. @nicolas-grekas This supersedes #25633 that's been in limbo since December despite your comments, so I decided to take care of it as I need this to work. I took care of the two loaders that are affected, and added tests. Commits ------- 948b4cf [Routing] Fixed the importing of files using glob patterns that match multiple resources
This fixes the import of resources specified using glob patterns in
XmlFileLoaderandYamlFileLoader.@nicolas-grekas This supersedes #25633 that's been in limbo since December despite your comments, so I decided to take care of it as I need this to work. I took care of the two loaders that are affected, and added tests.