[WebProfilerBundle] use the router to resolve file links #26626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 21, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #22290, #25886 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
commented
Mar 21, 2018
| <argument>?file=%%f&line=%%l#line%%l</argument> | ||
| </argument> | ||
| </service> | ||
| </argument> |
There was a problem hiding this comment.
this generates the following code, which is exactly what we need here:
new \Symfony\Component\HttpKernel\Debug\FileLinkFormatter(NULL, ($this->services['request_stack'] ?? $this->services['request_stack'] = new \Symfony\Component\HttpFoundation\RequestStack()), $this->targetDirs[3], \implode(array(0 => ($this->services['router'] ?? $this->getRouterService())->generate('_profiler_open_file'), 1 => '?file=%f&line=%l#line%l')));
fabpot
approved these changes
Mar 22, 2018
| @@ -56,7 +56,20 @@ | |||
| <argument>%debug.file_link_format%</argument> | |||
| <argument type="service" id="request_stack" on-invalid="ignore" /> | |||
| <argument>%kernel.project_dir%</argument> | |||
| <argument>/_profiler/open?file=%%f&line=%%l#line%%l</argument> | |||
| <argument type="service"> | |||
| <service class="string"> | |||
| <argument>/_profiler/open?file=%%f&line=%%l#line%%l</argument> | ||
| <argument type="service"> | ||
| <service class="string"> | ||
| <factory function="implode" /> |
There was a problem hiding this comment.
oh, and yet another nice hack!
Well done :)
|
@nicolas-grekas my head exploded when trying to understand this ... but I'm glad this is working 🎉 However, the main concern of Fabien in the other PR (see #24153 (comment)) was the configurability of this. So, can you please paste an example of the config needed if the user wants to customize the URL? We'd need it to update the docs. Thanks! |
|
@javiereguiluz there is no config needed, the URL will be generated based on the path of the |
xabbuh
approved these changes
Mar 22, 2018
javiereguiluz
approved these changes
Mar 22, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Mar 22, 2018
…nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [WebProfilerBundle] use the router to resolve file links | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22290, #25886 | License | MIT | Doc PR | - Commits ------- 2cfc573 [WebProfilerBundle] use the router to resolve file links
|
It creates a BC break as router tries to generate route on container dumping. We have routes in database and at the end database is checked on container generation (cache:clear command) |
|
Same here with The 'ci' environment loads the |
|
Shall we revert? |
|
It depends on the time we want, fix in progress, could be ready tomorrow. |
|
Fix in #26758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.