Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass() #26636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2018
Merged

[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass() #26636

merged 1 commit into from
Mar 22, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Mar 22, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Needs #26634

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Mar 22, 2018
@stof
Copy link
Member

stof commented Mar 22, 2018

I would also make it return false all the time (maybe even in 4.0), as no reference can be auto-registered in 4.0 😄

@nicolas-grekas nicolas-grekas force-pushed the di-deprec-autoreg branch 2 times, most recently from fdbddaa to 4137a30 Compare March 22, 2018 13:58
@nicolas-grekas nicolas-grekas changed the title [DI] deprecate TypedReference::canBeAutoregistered() [DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass() Mar 22, 2018
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Mar 22, 2018 •
edited
Loading

This PR now also deprecates TypedReference::getRequiringClass() since it's also not used.

return false all the time

hum, I'd better not do this, for hypothetical BC breaks and easing merges...

@nicolas-grekas nicolas-grekas mentioned this pull request Mar 22, 2018
Merged
@nicolas-grekas nicolas-grekas merged commit 95fd81b into symfony:master Mar 22, 2018
nicolas-grekas added a commit that referenced this pull request Mar 22, 2018
@nicolas-grekas
feature #26636 [DI] deprecate TypedReference::canBeAutoregistered() a…
61da487 
…nd getRequiringClass() (nicolas-grekas)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

~Needs #26634~

Commits
-------

95fd81b [DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()
@nicolas-grekas nicolas-grekas deleted the di-deprec-autoreg branch March 22, 2018 14:57
@javiereguiluz javiereguiluz mentioned this pull request Mar 23, 2018
Closed
@fabpot fabpot mentioned this pull request May 7, 2018
Merged
@linaori linaori mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection Deprecation Status: Needs Review
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @stof @carsonbot