[SecurityBundle] Added an alias from RoleHierarchyInterface to security.role_hierarchy #26639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Mar 22, 2018
| @@ -96,6 +96,7 @@ | |||
| <service id="security.role_hierarchy" class="Symfony\Component\Security\Core\Role\RoleHierarchy"> | |||
| <argument>%security.role_hierarchy.roles%</argument> | |||
| </service> | |||
| <service id="Symfony\Component\Security\Core\Role\RoleHierarchy" alias="security.role_hierarchy" /> | |||
There was a problem hiding this comment.
Should be RoleHierarchyInterface to me
There was a problem hiding this comment.
Arf, I noticed that too, but it looks like I forgot to push. Thanks.
…ty.role_hierarchy
d7ba849 to
886b8a6
Compare
nicolas-grekas
approved these changes
Mar 22, 2018
xabbuh
approved these changes
Mar 22, 2018
chalasr
approved these changes
Mar 23, 2018
|
Thank you @lyrixx. |
chalasr
pushed a commit
that referenced
this pull request
Mar 23, 2018
…rface to security.role_hierarchy (lyrixx) This PR was merged into the 4.1-dev branch. Discussion ---------- [SecurityBundle] Added an alias from RoleHierarchyInterface to security.role_hierarchy | Q | A | ------------- | --- | Branch? | master | Bug fix? | I don't know | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | It's needed for autowirering --- Note: I'm not sure if this is a bug fix or a new feature. Commits ------- 886b8a6 [SecurityBundle] Added an alias from RoleHierarchyInterface to security.role_hierarchy
|
Will this be backported to 3.4? |
|
@buffcode No, it's a new feature and all new features go to master. |
|
Thanks for clarification, yeah I know it is easy to add. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed for autowirering
Note: I'm not sure if this is a bug fix or a new feature.