[Messenger] Clone messages to show in profiler #26650
Conversation
|
|
||
| {% block toolbar %} | ||
| {% set color_code = 'normal' %} | ||
| {% set message_count = 0 %} |
There was a problem hiding this comment.
@sroze Any reason why this was zero?
There was a problem hiding this comment.
Nop, very likely a mistake 🙊
| <tr> | ||
| <td>{{ message.message.type }}</td> | ||
| <td> | ||
| {{ message.message.type }} |
There was a problem hiding this comment.
I don't believe we still need to display the type anymore if we use the dumper, as the FQCN is available as overlay :)
| {{ message.exception.type }} | ||
| {% endif %} | ||
|
|
||
| {% if message.result.object is defined %} |
There was a problem hiding this comment.
Same idea. If defined, I'd display this instead of the message.result.type.
|
|
||
| {% block toolbar %} | ||
| {% set color_code = 'normal' %} | ||
| {% set message_count = 0 %} |
There was a problem hiding this comment.
Nop, very likely a mistake 🙊
|
Thank you for the review
|
| 'type' => get_class($result), | ||
| 'object' => $this->cloneVar($result), | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
should be cloned as well in case it is an array, as it might contain objects inside the array
There was a problem hiding this comment.
btw, the template does not seem to use the value in this case when rendering the info, so why storing it ?
|
IMO, messages should not be stored directly in |
|
Thank you for the review |
5700de0 to
52f4da9
Compare
|
Done |
| } | ||
|
|
||
| $this->data[] = $debugRepresentation; | ||
| $this->data['messages'][] = $debugRepresentation; |
There was a problem hiding this comment.
collect must ensure that $this->data['messages'] is always an array, even when no message was handled there, to make getMessages work without notice after collect has been called.
There was a problem hiding this comment.
@Nyholm your changes did not fix this btw 😉
There was a problem hiding this comment.
Doesn't it?
Cant I trust that $this->data always to be null or an array?
There was a problem hiding this comment.
Actually, you're right, it won't "throw" a PHP notice.
| } | ||
|
|
||
| $this->data[] = $debugRepresentation; | ||
| $this->data['messages'][] = $debugRepresentation; |
There was a problem hiding this comment.
@Nyholm your changes did not fix this btw 😉
| } | ||
|
|
||
| $this->data[] = $debugRepresentation; | ||
| $this->data['messages'][] = $debugRepresentation; |
There was a problem hiding this comment.
Actually, you're right, it won't "throw" a PHP notice.
| public function getMessages(): array | ||
| { | ||
| return $this->data; | ||
| if (!isset($this->data['messages'])) { |
There was a problem hiding this comment.
return $this->data['messages'] ?? array();(note the array(), this will make fabbot happy)
|
Thank you |
ff354df to
359a658
Compare
|
I've rebased this PR now. Im ready for a final review. |
|
Thank you @Nyholm. |
This PR was squashed before being merged into the 4.1-dev branch (closes #26650). Discussion ---------- [Messenger] Clone messages to show in profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | na | License | MIT | Doc PR | na We should make the profiler page more pretty by using the cloner.  Commits ------- 4d1be87 [Messenger] Clone messages to show in profiler
We should make the profiler page more pretty by using the cloner.