Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Added a TransitionException #26651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 23, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26587 #26581
License MIT
Doc PR

Note for reviewer: NotEnabledTransitionException and UndefinedTransitionException were not released. So this is not a BC Break.

@lyrixx
Copy link
Member Author

lyrixx commented Mar 23, 2018

Thank you @andrewtch.

@lyrixx lyrixx merged commit 838548c into symfony:master Mar 23, 2018
lyrixx added a commit that referenced this pull request Mar 23, 2018
…ixx)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Workflow] Added a TransitionException

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26587 #26581
| License       | MIT
| Doc PR        |

---

Note for reviewer: `NotEnabledTransitionException` and `UndefinedTransitionException` were not released. So this is not a BC Break.

Commits
-------

838548c Finished implementation of TransitionException
9fa4f79 implemented TransitionException to be thrown instead of Logic exception
@lyrixx lyrixx deleted the andrewtch-transition-exception-for-workflow branch March 23, 2018 11:01
@fabpot fabpot mentioned this pull request May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants