[Translation] XLIFF2: Make sure to trim source if it is too long for "name" #26661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e485a5b to
ca41fec
Compare
|
I've rebased my PR on master to make Travis happy. |
|
I'm not sure about this because translations will have different kinds of <trans-unit id="http_error_403.suggestion"> ... </trans-unit>
<trans-unit id="ca41fec"> ... </trans-unit>Why can't we just apply this md5 ID to all translation nodes? Why it's important to duplicate the translation contents in the |
|
As mentioned in #25758
So we use |
fabpot
approved these changes
Mar 30, 2018
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2018
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in #26149 Commits ------- ca41fec Make sure to trim source if it is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302
This feature was introduced in #26149