[Console] Add box-double table style #26693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 28, 2018
UPGRADE-4.1.md
Outdated
| Serializer | ||
| ---------- | ||
|
|
||
| * Decoding XML with `XmlEncoder` now ignores comment node types by default. |
| * </code> | ||
| * | ||
| * @param string $outside Outside border char (see #1 of example) | ||
| * @param string|null $inside Outside border char (see #2 of example), equals $outside if null |
| */ | ||
| public function setVerticalBorderChar($verticalBorderChar) | ||
| { | ||
| $this->verticalBorderChar = $verticalBorderChar; | ||
| @trigger_error(sprintf('Method %s() is deprecated since Symfony 4.1. Use setVerticalBorderChars() instead.', __METHOD__), E_USER_DEPRECATED); |
There was a problem hiding this comment.
Deprecating a non-internal method in favor of an internal one looks weird to me.
There was a problem hiding this comment.
This one isn't internal. Are you talking about getBorderChars() maybe?
a8d1195 to
8c2a59e
Compare
fabpot
requested changes
Mar 30, 2018
| */ | ||
| public function setVerticalBorderChar($verticalBorderChar) | ||
| { | ||
| $this->verticalBorderChar = $verticalBorderChar; | ||
| @trigger_error(sprintf('Method %s() is deprecated since Symfony 4.1. Use setVerticalBorderChars() instead.', __METHOD__), E_USER_DEPRECATED); |
| */ | ||
| public function getVerticalBorderChar() | ||
| { | ||
| return $this->verticalBorderChar; | ||
| @trigger_error(sprintf('Method %s() is deprecated since Symfony 4.1. Use getBorderChars() instead.', __METHOD__), E_USER_DEPRECATED); |
There was a problem hiding this comment.
same here, use a comma instead of a dot.
8c2a59e to
463f986
Compare
fabpot
approved these changes
Mar 30, 2018
|
Thank you @maidmaid. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Add box-double table style | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25456 (review) | License | MIT | Doc PR | / In #25456 (review) @javiereguiluz suggested to have a complete configuration for style table. It was a nice idea, but not yet implemented. The box-drawing characters allow to combine different styles (like double/single lines). This PR give the possibility to use them. The previous #25456 introduced the box-drawing characters; this PR exploits all their strength.  See https://gist.github.com/maidmaid/3eb55afc4f2857cae89d7ac43d7943ae for some examples. Commits ------- 463f986 Add box-double table style
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #25456 (review) @javiereguiluz suggested to have a complete configuration for style table. It was a nice idea, but not yet implemented. The box-drawing characters allow to combine different styles (like double/single lines). This PR give the possibility to use them.
The previous #25456 introduced the box-drawing characters; this PR exploits all their strength.
See https://gist.github.com/maidmaid/3eb55afc4f2857cae89d7ac43d7943ae for some examples.