[FrameworkBundle] Fix validation configuration default test case #26782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9efb3b8 to
f336725
Compare
ogizanagi
reviewed
Apr 3, 2018
| @@ -259,7 +260,7 @@ class_exists(SemaphoreStore::class) && SemaphoreStore::isSupported() ? 'semaphor | |||
| 'entity_manager_name' => null, | |||
| ), | |||
| 'validation' => array( | |||
| 'enabled' => false, | |||
| 'enabled' => !class_exists(FullStack::class) && class_exists(Validation::class), | |||
There was a problem hiding this comment.
Should only be !class_exists(FullStack::class) as for other configurations. Which makes sense as the Validator component is always available in tests, being part of the require-dev section :)
There was a problem hiding this comment.
Hehe. I was pushing this change. Done 🙃
364288c to
4486734
Compare
4486734 to
235e037
Compare
fabpot
approved these changes
Apr 4, 2018
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Apr 4, 2018
…est case (sroze) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] Fix validation configuration default test case | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT This test case wasn't updated after a change in the PR to automatically enable the validation middleware based on the interface. Commits ------- 235e037 Fix validation configuration default test case
|
Thank you. Sorry for missing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case wasn't updated after a change in the PR to automatically enable the validation middleware based on the interface.