[WebProfilerBundle] Display uploaded files in the profiler #26946
Conversation
|
Looks awesome, as I watched in the |
| <th scope="col">File Name</th> | ||
| <th scope="col">MIME Type</th> | ||
| <th scope="col text-right">Size (bytes)</th> | ||
| <th scope="col">Temporary Location</th> |
There was a problem hiding this comment.
is this useful info? afaik, the temp file is gone when this is displayed, isn't it?
There was a problem hiding this comment.
You're right.
The file will be deleted from the temporary directory at the end of the request if it has not been moved away or renamed.
http://php.net/manual/en/features.file-upload.post-method.php
There was a problem hiding this comment.
@javiereguiluz Can you remove this column?
| <th scope="col">File Name</th> | ||
| <th scope="col">MIME Type</th> | ||
| <th scope="col text-right">Size (bytes)</th> | ||
| <th scope="col">Temporary Location</th> |
There was a problem hiding this comment.
@javiereguiluz Can you remove this column?
|
Thank you @javiereguiluz. |
…iler (javiereguiluz) This PR was squashed before being merged into the 4.2-dev branch (closes #26946). Discussion ---------- [WebProfilerBundle] Display uploaded files in the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26926 | License | MIT | Doc PR | -  Note: I wanted to use the VarDumper to display the table information (as we do in the rest of tables) but I had lots of problems and I just wanted to create a proof of concept for the feature to see if we like it. Commits ------- 3f6f75b [WebProfilerBundle] Display uploaded files in the profiler
|
Wouldn't it make sense to also display the error (possibly human readable) if any occurred during uploading? |
Note: I wanted to use the VarDumper to display the table information (as we do in the rest of tables) but I had lots of problems and I just wanted to create a proof of concept for the feature to see if we like it.