-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger][AmqpExt] Allow disabling the auto-setup of the connection #26956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1bf2589
to
9e8c56b
Compare
What happens if you attempt to publish to a non-existent exchange? I assume it will throw an exception? That makes sense to me since that's the same behavior that happens if you attempt to publish to a non-existent vhost. |
When you publish to a non-existent exchange, RabbitMq would not tell you anything, unfortunately. It would not throw an exception, so that's why we actually setup when |
Could we have an option to setup the exchange, but not the queue? |
I wouldn't go in this direction. If we do, we also need to be able to select if we bind the queue or not for example. I'd argue that either you use the automated configuration or you go ahead with your own. |
hmm, I guess it's fine. If there aren't any applications listening.. then it doesn't matter if the message falls out of the tubes. |
b99b069
to
b3039fa
Compare
… connection (sroze) This PR was squashed before being merged into the 4.1-dev branch (closes #26956). Discussion ---------- [Messenger][AmqpExt] Allow disabling the auto-setup of the connection | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26937 | License | MIT | Doc PR | ø Allow disabling the auto-setup of the AMQP connection. Especially useful when the messages are published to another system (see #26937) Commits ------- b3039fa [Messenger][AmqpExt] Allow disabling the auto-setup of the connection
How to use it ? |
since the default is |
I tried it right now and I have an error |
If you disabled auto-setup, then no. |
Note that in 4.3 (#30702), it is renamed to |
Allow disabling the auto-setup of the AMQP connection. Especially useful when the messages are published to another system (see #26937)