[DX] Redirect to proper Symfony version documentation #27104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
approved these changes
May 1, 2018
fabpot
requested changes
May 2, 2018
|
@fabpot understood, target blank removed |
|
The target branch is not good. It should be either 2.7 (bug fix) or master (new feature). |
|
This code does not exists on 2.x |
dunglas
approved these changes
May 3, 2018
|
Thank you @noniagriconomie. |
fabpot
added a commit
that referenced
this pull request
May 3, 2018
…(noniagriconomie) This PR was squashed before being merged into the 4.1-dev branch (closes #27104). Discussion ---------- [DX] Redirect to proper Symfony version documentation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | Just a small improvement I think this can make some dev target the right documentation instead of reading an other version that the one they are developing on EDIT: I do not know if including the constant directly is the good choice, or it is better to add a global symfony version collector? Commits ------- d611160 [DX] Redirect to proper Symfony version documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small improvement
I think this can make some dev target the right documentation instead of reading an other version that the one they are developing on
EDIT: I do not know if including the constant directly is the good choice, or it is better to add a global symfony version collector?