[Messenger] Add a new time limit receiver #27130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
reviewed
May 2, 2018
| private $timeLimit; | ||
| private $logger; | ||
|
|
||
| public function __construct(ReceiverInterface $decoratedReceiver, int $timeLimit, LoggerInterface $logger = null) |
There was a problem hiding this comment.
please name the variable like $timeLimitInSeconds to make it clear what unit this is in
Tobion
reviewed
May 2, 2018
| if ($endTime < time()) { | ||
| $this->stop(); | ||
| if (null !== $this->logger) { | ||
| $this->logger->info('Receiver stopped due to time limit of {timeLimit} reached', array('timeLimit' => $this->timeLimit)); |
|
|
||
| $timeoutReceiver = new StopWhenTimeLimitIsReachedReceiver($decoratedReceiver, 1, $logger); | ||
| $timeoutReceiver->receive(function () { | ||
| sleep(2); |
There was a problem hiding this comment.
in order to not really wait for 2s during tests, the test case should be @group time-sensitive
sroze
reviewed
May 3, 2018
| @@ -70,6 +72,10 @@ protected function configure(): void | |||
| Use the --memory-limit option to stop the worker if it exceeds a given memory usage limit. You can use shorthand byte values [K, M or G]: | |||
|
|
|||
| <info>php %command.full_name% <receiver-name> --memory-limit=128M</info> | |||
|
|
|||
| Use the --time-limit option to stop the worker if it the given time limit is reached: | |||
There was a problem hiding this comment.
- if it
+ when- given time limit
+ given time limit (in seconds)
sroze
approved these changes
May 4, 2018
Tobion
approved these changes
May 4, 2018
|
@sdelicata your commits have multiple authors: could you squash them into one for us please? |
|
@sroze Done ! |
|
Thank you @sdelicata. |
sroze
added a commit
that referenced
this pull request
May 4, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Add a new time limit receiver | Q | A | ------------- | --- | Branch? | master for features | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | License | MIT New feature to add a time limit option to the ConsumeMessagesCommand. ``` bin/console messenger:consume-messages <receiver-name> -t 3600 ``` Commits ------- 5536ee1 Add a new time limit receiver
Merged
lucchese-pd
reviewed
May 11, 2018
| if ($endTime < time()) { | ||
| $this->stop(); | ||
| if (null !== $this->logger) { | ||
| $this->logger->info('Receiver stopped due to time limit of {timeLimit}s reached', array('timeLimit' => $this->timeLimitInSeconds)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature to add a time limit option to the ConsumeMessagesCommand.